Closed
Bug 1465902
Opened 6 years ago
Closed 6 years ago
Do not send a bundle of messages if we do not have enough messages to fill the bundle
Categories
(Firefox :: Messaging System, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: ursula, Assigned: ursula)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
In testing, Aaron has encountered the case where there is only 1 onboarding message that is unblocked, and it needs to be bundled in a set of 3 onboarding messages, but we send it anyways and it looks bad. We need to check that amount of messages we send down in a bundle matches the number of items we want to show in the bundle.
See attachment to see the UI issue
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/12aaa5d918bfa249fb19ab63047ca5ad75d9b8cd
Fix Bug 1465902 - Do not send a bundle of messages if we do not have enough messages to fill the bundle
https://github.com/mozilla/activity-stream/commit/161ddc7d9d108df14744f3778d832660d60e77da
Merge pull request #4189 from sarracini/bug_1465902
Fix Bug 1465902 - Do not send a bundle of messages if we do not have enough messages to fill the bundle
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 3•6 years ago
|
||
status-firefox62:
--- → fixed
Target Milestone: --- → Firefox 62
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•