Closed
Bug 1466298
Opened 6 years ago
Closed 6 years ago
Get rid of nsIDOMGeoGeolocation
Categories
(Core :: DOM: Geolocation, enhancement)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
It's not needed.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8982766 -
Flags: review?(continuation)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8982767 -
Flags: review?(continuation)
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8982768 -
Flags: review?(continuation)
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8982771 -
Flags: review?(continuation)
Assignee | ||
Updated•6 years ago
|
Attachment #8982766 -
Attachment is obsolete: true
Attachment #8982766 -
Flags: review?(continuation)
Updated•6 years ago
|
Attachment #8982771 -
Flags: review?(continuation) → review+
Updated•6 years ago
|
Attachment #8982767 -
Flags: review?(continuation) → review+
Comment 5•6 years ago
|
||
Comment on attachment 8982768 [details] [diff] [review]
part 3. Remove nsIDOMGeoGeolocation
Review of attachment 8982768 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/geolocation/nsGeolocation.cpp
@@ -1181,5 @@
> ErrorResult& aRv)
> {
> nsresult rv = GetCurrentPosition(GeoPositionCallback(&aCallback),
> GeoPositionErrorCallback(aErrorCallback),
> - std::move(CreatePositionOptionsCopy(aOptions)),
I guess the moves are redundant?
Attachment #8982768 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 6•6 years ago
|
||
> I guess the moves are redundant?
Yeah. CreatePositionOptionsCopy returns an object by value; the moves are actually triggering the pessimizing-move warning...
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/837c9a6efe99
part 1. Switch the geolocation service to using a singleton constructor. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b156f1b15ae
part 2. Stop using do_GetService to get the non-window geolocation in C++ code. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc5f7be292e
part 3. Remove nsIDOMGeoGeolocation. r=mccr8
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/837c9a6efe99
https://hg.mozilla.org/mozilla-central/rev/1b156f1b15ae
https://hg.mozilla.org/mozilla-central/rev/2fc5f7be292e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•