Closed Bug 1466298 Opened 6 years ago Closed 6 years ago

Get rid of nsIDOMGeoGeolocation

Categories

(Core :: DOM: Geolocation, enhancement)

Product:
Core
Component:
DOM: Geolocation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files, 1 obsolete file)

part 2. Stop using do_GetService to get the non-window geolocation in C++ code
(deleted), patch
mccr8
: review+
Details | Diff | Splinter Review
part 3. Remove nsIDOMGeoGeolocation
(deleted), patch
mccr8
: review+
Details | Diff | Splinter Review
part 1. Switch the geolocation service to using a singleton constructor
(deleted), patch
mccr8
: review+
Details | Diff | Splinter Review
It's not needed.
Attachment #8982766 - Flags: review?(continuation)
Attachment #8982768 - Flags: review?(continuation)
Attachment #8982766 - Attachment is obsolete: true
Attachment #8982766 - Flags: review?(continuation)
Attachment #8982771 - Flags: review?(continuation) → review+
Attachment #8982767 - Flags: review?(continuation) → review+
Comment on attachment 8982768 [details] [diff] [review] part 3. Remove nsIDOMGeoGeolocation Review of attachment 8982768 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/geolocation/nsGeolocation.cpp @@ -1181,5 @@ > ErrorResult& aRv) > { > nsresult rv = GetCurrentPosition(GeoPositionCallback(&aCallback), > GeoPositionErrorCallback(aErrorCallback), > - std::move(CreatePositionOptionsCopy(aOptions)), I guess the moves are redundant?
Attachment #8982768 - Flags: review?(continuation) → review+
> I guess the moves are redundant? Yeah. CreatePositionOptionsCopy returns an object by value; the moves are actually triggering the pessimizing-move warning...
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/837c9a6efe99 part 1. Switch the geolocation service to using a singleton constructor. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/1b156f1b15ae part 2. Stop using do_GetService to get the non-window geolocation in C++ code. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc5f7be292e part 3. Remove nsIDOMGeoGeolocation. r=mccr8
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: