[css-grid-2] Implement subgrid support in track sizing
Categories
(Core :: Layout, enhancement, P2)
Tracking
()
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(11 files, 7 obsolete files)
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Comment 18•6 years ago
|
||
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:mats, could you have a look please?
Assignee | ||
Comment 27•6 years ago
|
||
Assignee | ||
Comment 28•6 years ago
|
||
Depends on D29149
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 29•6 years ago
|
||
Assignee | ||
Comment 30•6 years ago
|
||
Depends on D29240
Assignee | ||
Comment 31•6 years ago
|
||
Depends on D29241
Assignee | ||
Comment 32•6 years ago
|
||
FYI, Part 8 is still "work in progress" so I intentionally didn't request review
on that part yet. However, the GridReflowInput::CalculateTrackSizesForAxis /
CalculateTrackSizes methods are mostly just refactoring existing code, and
CopyUsedTrackSizes is somewhat stable, so you can review those bits if you want.
I included it so that you can start reviewing part 9/10. (The iffy parts are
the added code in ContentContribution(), that calls UsedTrackSizes::ResolveTrackSizesForAxis
and then ResolveSubgridTrackSizesForAxis, all to determine a CB size in
the opposite axis for min/max-content sizing of a subgrid item. I'm trying
to simplify that code a bit...)
These are all the code parts, BTW. Still working on WPTs...
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Comment 34•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 35•6 years ago
|
||
Comment 36•5 years ago
|
||
Comment 37•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/92d9b8b245c4
https://hg.mozilla.org/mozilla-central/rev/9abb8c91398c
https://hg.mozilla.org/mozilla-central/rev/1a6bf3c650d7
https://hg.mozilla.org/mozilla-central/rev/c619ca5a135b
https://hg.mozilla.org/mozilla-central/rev/bf5027913782
https://hg.mozilla.org/mozilla-central/rev/85788d6cb290
https://hg.mozilla.org/mozilla-central/rev/4e4f1fb1ffdd
https://hg.mozilla.org/mozilla-central/rev/003d3db59a1f
https://hg.mozilla.org/mozilla-central/rev/6e90ed77e910
https://hg.mozilla.org/mozilla-central/rev/bfc4f4f153eb
https://hg.mozilla.org/mozilla-central/rev/f21f62a36c12
Updated•5 years ago
|
Description
•