Closed Bug 1466487 Opened 6 years ago Closed 6 years ago

Crash [@ ??] or Assertion failure: func, at builtin/ModuleObject.cpp:1658 with evalInWorker and ES6 Modules

Categories

(Core :: JavaScript Engine, defect, P3)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed

People

(Reporter: decoder, Assigned: jonco)

References

(Regression)

Details

(5 keywords, Whiteboard: [jsbugmon:update])

Attachments

(1 file)

The following testcase crashes on mozilla-central revision ad1249c83efb (build with --enable-posix-nspr-emulation --enable-valgrind --enable-gczeal --disable-tests --disable-profiling --disable-debug --enable-optimize, run with --fuzzing-safe --ion-offthread-compile=off): evalInWorker(` let m = parseModule("import.meta;"); m.declarationInstantiation(); m.evaluation(); `); Backtrace: received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffff48ff700 (LWP 7266)] 0x0000000000000000 in ?? () #0 0x0000000000000000 in ?? () #1 0x00000000005ab3e1 in js::GetOrCreateModuleMetaObject (cx=0x7ffff491a000, moduleArg=...) at js/src/builtin/ModuleObject.cpp:1659 #2 0x000000000055e44e in Interpret (cx=0x7ffff491a000, state=...) at js/src/vm/Interpreter.cpp:4256 #3 0x000000000056634a in js::RunScript (cx=0x7ffff491a000, state=...) at js/src/vm/Interpreter.cpp:421 #4 0x00000000005683d6 in js::ExecuteKernel (result=0x7ffff5f9d1f0, evalInFrame=..., newTargetValue=..., envChainArg=..., script=..., cx=0x7ffff491a000) at js/src/vm/Interpreter.cpp:704 #5 js::Execute (cx=cx@entry=0x7ffff491a000, script=script@entry=..., envChainArg=..., rval=rval@entry=0x7ffff5f9d1f0) at js/src/vm/Interpreter.cpp:737 #6 0x00000000005a610d in js::ModuleObject::execute (cx=0x7ffff491a000, self=..., self@entry=..., rval=...) at js/src/builtin/ModuleObject.cpp:1127 #7 0x0000000000a09358 in intrinsic_ExecuteModule (cx=<optimized out>, argc=<optimized out>, vp=<optimized out>) at js/src/vm/SelfHosting.cpp:2217 #8 0x00000000005666d1 in js::CallJSNative (args=..., native=0xa09310 <intrinsic_ExecuteModule(JSContext*, unsigned int, JS::Value*)>, cx=0x7ffff491a000) at js/src/vm/JSContext-inl.h:274 [...] #16 0x0000000000460ead in WorkerMain (arg=<optimized out>) at js/src/shell/js.cpp:3631 [...] #20 0x00007ffff6c383dd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 rax 0x7ffff4905000 140737296486400 rbx 0x7ffff48fe040 140737296457792 rcx 0x7ffff4600500 140737293321472 rdx 0x7ffff48fde00 140737296457216 rsi 0x7ffff48fe040 140737296457792 rdi 0x7ffff491a000 140737296572416 rbp 0x7ffff491a000 140737296572416 rsp 0x7ffff48fdde8 140737296457192 r8 0x1e6f340 31912768 r9 0x7ffff4503100 140737292284160 r10 0x7ffff48fe420 140737296458784 r11 0xfffb000000000000 -1407374883553280 r12 0x7ffff48fe460 140737296458848 r13 0x1e6ac60 31894624 r14 0x7ffff491a748 140737296574280 r15 0x7ffff491a000 140737296572416 rip 0x0 0 => 0x0: Null-jump, not marking s-s.
Whiteboard: [jsbugmon:update,bisect] → [jsbugmon:update]
JSBugMon: Bisection requested, result: autoBisect shows this is probably related to the following changeset: The first bad revision is: changeset: https://hg.mozilla.org/mozilla-central/rev/277bd9cf9edc user: Jon Coppeard date: Wed May 23 08:47:28 2018 +0100 summary: Bug 1427610 - Implement import.meta in the JS frontent r=jorendorff This iteration took 243.713 seconds to run.
This is a shell-only issue.
Crash Signature: [@ ??]
Priority: -- → P3
Attached patch bug1466487-import-meta-hook (deleted) — Splinter Review
Patch to check for the metadata hook being set rather than asserting it.
Assignee: nobody → jcoppeard
Attachment #8983367 - Flags: review?(andrebargull)
Comment on attachment 8983367 [details] [diff] [review] bug1466487-import-meta-hook Review of attachment 8983367 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable.
Attachment #8983367 - Flags: review?(andrebargull) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/450557c0669f Throw if module metadata hook is not set in the shell r=anba
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Regressed by: 1427610
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: