This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.

Comment on attachment 8983018 [details] Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for head_devtools_inspector_sidebar.js. This change is upsetting browser_ext_devtools_panels_elements_sidebar.js that seems to import the head file. Cancelling review whilst I take a look.

Comment on attachment 8983019 [details] Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for storage/test/unit. https://reviewboard.mozilla.org/r/248882/#review255226

Comment on attachment 8983018 [details] Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for head_devtools_inspector_sidebar.js. https://reviewboard.mozilla.org/r/248880/#review255386 Thanks for the patch! ::: devtools/client/inspector/extensions/test/head_devtools_inspector_sidebar.js:42 (Diff revision 2) > // on the remote debugging server > // (used in browser_ext_devtools_panels_elements_sidebar.js). > async function expectNoSuchActorIDs(client, actors) { > info(`Test that all the objectValueGrip actors have been released`); > for (const actor of actors) { > + const re = new RegExp(`No such actor for ID: ${actor}`); Could we do a string comparison rather than using a regexp built from string concatenation?

Comment on attachment 8983018 [details] Bug 1466497 - Enable ESLint rule require-expected-throws-or-rejects for head_devtools_inspector_sidebar.js. https://reviewboard.mozilla.org/r/248880/#review255386 > Could we do a string comparison rather than using a regexp built from string concatenation? Yes, now that we're using the function form. I was getting too obsessed by RegExps :-)

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9c090ac9e24 Enable ESLint rule require-expected-throws-or-rejects for head_devtools_inspector_sidebar.js. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/e83a2d180ff5 Enable ESLint rule require-expected-throws-or-rejects for storage/test/unit. r=mak

https://hg.mozilla.org/mozilla-central/rev/c9c090ac9e24 https://hg.mozilla.org/mozilla-central/rev/e83a2d180ff5