It has this allowSameCompartment argument that defaults to DONT_ALLOW_CROSS_COMPARTMENT. Looking at (some of) the callers, I think changing this to allowSameRealm is the right thing to do.

This adds a separate DescribeScriptedCallerForDirectEval function, instead of handling this case in DescribeScriptedCallerForCompilation. It's a bit simpler and it eliminates a cx->currentScript call for direct evals: the callers already know the JSOP_EVAL script/pc.

With some minor cleanup.

Comment on attachment 8985643 [details] [diff] [review] Part 2 - Some DescribeScriptedCallerForCompilation cleanup Review of attachment 8985643 [details] [diff] [review]: ----------------------------------------------------------------- Nice!

Comment on attachment 8985646 [details] [diff] [review] Part 3 - Check realms instead of compartments in JSContext::currentScript Review of attachment 8985646 [details] [diff] [review]: ----------------------------------------------------------------- Good catch

Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c4e97614565 part 1 - Pass script to GetIntrinsicOperation so it doesn't have to look it up. r=tcampbell https://hg.mozilla.org/integration/mozilla-inbound/rev/92d154bc6515 part 2 - Some DescribeScriptedCallerForCompilation cleanup. r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/40461ea89e0c part 3 - Check realms instead of compartments in JSContext::currentScript. r=luke

https://hg.mozilla.org/mozilla-central/rev/0c4e97614565 https://hg.mozilla.org/mozilla-central/rev/92d154bc6515 https://hg.mozilla.org/mozilla-central/rev/40461ea89e0c