Closed Bug 1466851 Opened 6 years ago Closed 6 years ago

Remove some unused tree box object bits

Categories

(Core :: XUL, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(3 files)

No description provided.
These properties are not used from either JS or C++, and hence can be removed from both nsITreeBoxObject and TreeBoxObject.webidl. Properties in this bucket: scrollToCell, scrollToColumn, scrollToHorizontalPosition, invalidateColumnRange.
Attachment #8983514 - Flags: review?(dtownsend)
These properties are unused from C++ and the FakeTreeBoxObject implementations in comm-central are throwing stubs. So it's safe to remove the properties from nsITreeBoxObject (but not TreeBoxObject.webidl, since they're used in JS). Properties in this bucket: horizontalPosition, getPageLength.
Attachment #8983518 - Flags: review?(dtownsend)
Priority: -- → P5
These properties are unused from C++ apart from webidl bindings and the FakeTreeBoxObject implentations in comm-central are throwing stubs. But they're used in JS. They are safe to remove from nsITreeBoxObject but we need to keep an implementation webidl can call into. Properties in this bucket: selectionRegion, ensureCellIsVisible, scrollToRow, scrollByLines, scrollByPages, getRowAt, removeImageCacheEntry.
Attachment #8983519 - Flags: review?(dtownsend)
Attachment #8983514 - Flags: review?(dtownsend) → review+
Attachment #8983518 - Flags: review?(dtownsend) → review+
Attachment #8983519 - Flags: review?(dtownsend) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b8e7ac3a4a5 part 1. Remove some unused tree box object properties. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/99016a1b4105 part 2. Remove some nsITreeBoxObject properties that are unused from C++. r=mossop https://hg.mozilla.org/integration/mozilla-inbound/rev/ada451d2e78d part 3. Remove some nsITreeBoxObject properties that are unused except via webidl bindings. r=mossop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: