tgn-ff Reporter
	Description • 6 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180606100133

Steps to reproduce:

1. Create a new profile.
2. Install the following extensions: uBlock Origin [1], Greasemonkey [2], Simple Translate [3].
3. Restart Nightly (Build ID 20180606100133) twice.
4. Click on the extensions' icon.


[1]: https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/
[2]: https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/
[3]: https://addons.mozilla.org/en-US/firefox/addon/simple-translate/


Actual results:

Simple Translate works as it should. uBO and GM don't work. If you disable and re-enable them in about:addons, they start working again.

If you start the profile with a previous version (I used the current Release), then the extensions work in Nightly too, but for one time only. If you re-start Nightly, the extensions stop working. This is why I suggested to restart Nightly twice in STR.


Expected results:

Every extension should work without the need to disable/re-enable it in the add-ons' manager.

Bisection points to Bug 1369841.

Mozregression log:
 4:12.24 INFO: Last good revision: 6646425c8cd10440f2ce38cd594be0c84a7c21fa
 4:12.24 INFO: First bad revision: f6c89ca4944b0233e08463ce4825812c1b08373c
 4:12.24 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6646425c8cd10440f2ce38cd594be0c84a7c21fa&tochange=f6c89ca4944b0233e08463ce4825812c1b08373c

	Alice0775 White
	Comment 1 • 6 years ago

[Tracking Requested - why for this release]:

	Alice0775 White
	Comment 2 • 6 years ago

[Tracking Requested - why for this release]:WebExtension does not work on Nightly62.0a1

I can reproduce the issue on Win10 x64 Nightly62.0a1.

	Alice0775 White
	Comment 3 • 6 years ago

Actual Results:
In a rough looking,(Although it may have further problems when testing it in deep)
uBlock Origin: Count(on this page, since install) is not shown in popup
GreaseMonkey: popup is empty
Simple Translate: "Translate this page" link is not shown in popup

	Alice0775 White
	Comment 4 • 6 years ago

this is a regression by bug 1369841.

	Andrew Swan [:aswan] Assignee
	Comment 5 • 6 years ago

Ah, the patch for bug 1369841 is incomplete, we don't clear primed listeners if the background page starts through a method other than messaging.  I should be able to have a patch ready today.
In the mean time, anybody affected by this should be able to work it this by setting extensions.webextensions.background-delayed-startup to false.

	Kris Maglione [:kmag]
	Comment 7 • 6 years ago
mozreview-review

Comment on attachment 8983955 [details]
Bug 1467136 Ensure extension messaging cannot miss the startup event

https://reviewboard.mozilla.org/r/249804/#review255996

::: toolkit/components/extensions/test/xpcshell/test_ext_messaging_startup.js:193
(Diff revision 1)
> +    async background() {
> +      browser.runtime.onMessage.addListener(msg => {
> +        browser.test.notifyPass("startup");
> +      });
> +
> +      await browser.runtime.getBrowserInfo();

Please add a comment about why we're doing this. It's non-obvious.

::: toolkit/components/extensions/test/xpcshell/test_ext_messaging_startup.js:211
(Diff revision 1)
> +  await extension.awaitMessage("bg-ran");
> +
> +  await promiseRestartManager();
> +  await extension.awaitStartup();
> +
> +  Services.obs.notifyObservers(null, "sessionstore-windows-restored");

Comment about why we're doing this too, please.

	Pulsebot
	Comment 9 • 6 years ago

Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a1ad8e3467d
Ensure extension messaging cannot miss the startup event r=kmag

	Jules A
	Comment 10 • 6 years ago

Updating to latest Nightly build (20180606220131) caused all Webextensions to break (reloading page didn't fix) after the update process completed (from the UI prompt) even with extensions.webextensions.background-delayed-startup set to false. Previously updating would cause extensions to not work straight after updating but refreshing the page would load the extensions properly.
Restarting the browser caused all extensions to appear like they are working but Reddit Enhancement Suite breaks when navigating to any subreddit. This is still with extensions.webextensions.background-delayed-startup set to false and build 20180606220131.

	Cristina Coroiu [:ccoroiu]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8a1ad8e3467d

	Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
	Comment 12 • 6 years ago

I'm confirming that issue is fixed, starting in Mozilla Firefox Nightly 62.0a1 (2018-06-07), so I'm marking this bug as VERIFIED. Thank you very much! \o/

	gwarser
	Comment 14 • 6 years ago

Should this be fixed in 20180607100059? Because even if UBO popup looks good some request get through. For example I have gravatar blocked by dynamic filtering, but avatars in this page sometimes load. Reddit Enhancements Suite consistently stops working when I refresh reddit thread (example page: https://old.reddit.com/r/firefox/comments/8pb8kh/todays_nightly_update_seems_to_have_broken_res_is/ ), starts working again when disabled->enabled from about:addons Another broken extension is https://addons.mozilla.org/en-US/firefox/addon/drag-select-link-text/ - I cannot select links text when I see avatars here, or when RES stops working.

	Jules A
	Comment 15 • 6 years ago

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #12)
> I'm confirming that issue is fixed, starting in Mozilla Firefox Nightly
> 62.0a1 (2018-06-07), so I'm marking this bug as VERIFIED. Thank you very
> much! \o/

See my previous post and gwarser's post, it is not fixed for all Webextensions, RES is still very broken.

	Andrew Swan [:aswan] Assignee
	Comment 16 • 6 years ago

Please file a new bug with a more specific description of what you're seeing (ie, steps to reproduce, expected results, actual results)

	tgn-ff Reporter
	Comment 17 • 6 years ago

uBO seems to work on my end. RES and other extensions, stop working after reloading the page, but a patch in a different bug seems to be responsible. I filed Bug 1467727.

Gesturefy [1], that a user on reddit reported, also, stops working after the page is reloaded, but I didn't include it in my test in 1467727. Since it looks too similar to be different, I'll wait to see if it's fixed along with the other extensions in Bug 1467727 and I'll file a new bug if it's not. Unless, of course, someone else tests it first.


[1]: https://addons.mozilla.org/en-US/firefox/addon/gesturefy/

	Gary [:streetwolf52]
	Comment 18 • 6 years ago

An Add-on called Bitwarden, which is a password manager, is impacted too.  It's auto fill feature works perhaps the first time a sites login info is auto filled.  After that, sites are not auto filled.  There were a few other problems which appear to have been fixed by some patch.