Jan de Mooij [:jandem] Assignee
	Description • 6 years ago

I just realized bug 1363214 broke this because the guard is always false if we compare a JSCompartment* to obj->group->realm_. I think it's okay for this code to guard on the compartment and to accept same-realm compartments.

	Jan de Mooij [:jandem] Assignee
	Comment 1 • 6 years ago

Note that this introduces an extra load. I think that's fine and we should be able to remove these ICs eventually anyway.

	Jan de Mooij [:jandem] Assignee
	Comment 2 • 6 years ago

(In reply to Jan de Mooij [:jandem] from comment #0)
> guard on the compartment and to accept same-realm compartments.

Er, same-compartment realms :)

	Ted Campbell [:tcampbell]
	Comment 3 • 6 years ago

Comment on attachment 8983786 [details] [diff] [review]
Patch

Review of attachment 8983786 [details] [diff] [review]:
-----------------------------------------------------------------

Good find. Extra load is likely fine as these ICs are already complicated.

	Pulsebot
	Comment 4 • 6 years ago

Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b760c430347
Fix MacroAssembler::branchTestObjCompartment to guard on realm->compartment instead of realm. r=tcampbell

	Cristina Coroiu [:ccoroiu]
	Comment 5 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7b760c430347