Closed
Bug 1467335
Opened 6 years ago
Closed 6 years ago
Add an assertion to ungetCharIgnoreEOL that the EOF-flag has been set if EOF is being returned
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
A basic "why haven't we done this already for belt-and-suspenders awareness" sort of thing.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8984000 -
Flags: review?(arai.unmht)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8984000 [details] [diff] [review]
Patch
Review of attachment 8984000 [details] [diff] [review]:
-----------------------------------------------------------------
makes sense :)
Attachment #8984000 -
Flags: review?(arai.unmht) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de25c66a84b0
Add an assertion to ungetCharIgnoreEOL that the EOF-flag has been set if EOF is being returned. r=arai
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•