Closed Bug 1467485 Opened 6 years ago Closed 6 years ago

Missing screenshots for TopSiteLink components in Nightly

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 62
Iteration:
62.3 - Jun 18
Tracking Status
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified

People

(Reporter: imjching, Assigned: imjching)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image missing_screenshots_for_topsites.png (deleted) —
Screenshots.getScreenshotForURL was modified to return an object instead of a string in the patch for Bug #1436615 (https://github.com/mozilla/activity-stream/blob/7e544945fbe0cba46eba9387e4c593e98d8f9f55/lib/Screenshots.jsm#L45). We need to handle those blob objects in the TopSiteLink component as well because it is treating the inputs as base64 strings: https://github.com/mozilla/activity-stream/blob/7e544945fbe0cba46eba9387e4c593e98d8f9f55/content-src/components/TopSites/TopSite.jsx#L89. I am working on a patch for this at the moment. Thanks :mconley for bringing this up!
Iteration: --- → 62.3 - Jun 18
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/b92c8c6068e5f9bb8b8df7d2b2bcbfe7226a752e fix(topsites): Share blob handling utils with top sites and cards (#4198) Fix Bug 1467485 - Missing screenshots for TopSiteLink components in Nightly Signed-off-by: Jay Lim <6175557+imjching@users.noreply.github.com>
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1467858
Depends on: 1436615
Blocks: 1445085
Target Milestone: --- → Firefox 62
I'm still seeing this in latest Nightly, is it expected?
It's still waiting on review in bug 1467858.
This issue is no longer reproducible on the latest Nightly (62.0a1 - Build ID 20180615100050). Now each "Top Site" has its screenshot successfully displayed. Verified on Windows 10 x64, Ubuntu 16.04 x64 and Mac 10.13.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: