This code is loaded unconditionally in browser-content.js, but it could be instantiated only when used. Not only that, this feature is actually disabled by default, so we should skip loading it unless it's toggled on.

Comment on attachment 8984288 [details] Bug 1467586 - Part 0. hg cp the DateTimePickerListener object to a new file, and rename the DateTimePickerHelper. https://reviewboard.mozilla.org/r/250096/#review256776 Thanks!

Comment on attachment 8984289 [details] Bug 1467586 - Convert the DateTimePickerListener object into a class to be instantiated when needed. https://reviewboard.mozilla.org/r/250098/#review256778 This is great! Assuming this passes the datetime picker mochitests, this looks good to go from me. Good work!

I made a small change because I misunderstood the meaning of the pref. The pref only blocks the code for input type="time", but this code is also used for input type="date". So I moved the pref check back to its original location, and then just declared the object as a lazy proxy.

Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5f8e35e87a21 Part 0. hg cp the DateTimePickerListener object to a new file, and rename the DateTimePickerHelper. r=mconley https://hg.mozilla.org/integration/autoland/rev/79476ed91dec Convert the DateTimePickerListener object into a class to be instantiated when needed. r=mconley

https://hg.mozilla.org/mozilla-central/rev/5f8e35e87a21 https://hg.mozilla.org/mozilla-central/rev/79476ed91dec