Closed
Bug 1467915
Opened 6 years ago
Closed 6 years ago
Give a surface to background sessions in TestRunnerActivity
Categories
(GeckoView :: General, enhancement, P2)
Tracking
(firefox62 wontfix, firefox63 fixed)
RESOLVED
FIXED
mozilla63
People
(Reporter: snorp, Assigned: snorp)
References
Details
Attachments
(1 file)
Some tests use window.open() and then run things that need the compositor to function properly, e.g. off main thread animations. We need to give background sessions a Surface for this to work.
Assignee | ||
Updated•6 years ago
|
Blocks: mochitest-gv
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8984604 [details]
Bug 1467915 - Connect a display to background windows in TestRunnerActivity
https://reviewboard.mozilla.org/r/250476/#review256934
::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:121
(Diff revision 1)
> + session.acquireDisplay().surfaceChanged(surface, mView.getWidth(), mView.getHeight());
> + return session;
> + }
> +
> + private void closeSession(GeckoSession session) {
> + session.acquireDisplay().surfaceDestroyed();
Should be calling `releaseDisplay` instead of `acquireDisplay`.
::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:121
(Diff revision 1)
> + session.acquireDisplay().surfaceChanged(surface, mView.getWidth(), mView.getHeight());
> + return session;
> + }
> +
> + private void closeSession(GeckoSession session) {
> + session.acquireDisplay().surfaceDestroyed();
Should be calling `releaseDisplay` instead of `acquireDisplay`.
Attachment #8984604 -
Flags: review?(nchen) → review-
Updated•6 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8984604 [details]
Bug 1467915 - Connect a display to background windows in TestRunnerActivity
https://reviewboard.mozilla.org/r/250476/#review260416
::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:115
(Diff revision 2)
> final GeckoSession session = new GeckoSession(settings);
> session.setNavigationDelegate(mNavigationDelegate);
> return session;
> }
>
> + private GeckoSession createBackgroundSession(GeckoSessionSettings settings) {
final.
Attachment #8984604 -
Flags: review?(esawin) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3820ad4c882b
Connect a display to background windows in TestRunnerActivity r=esawin
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment 7•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Assignee: nobody → snorp
Assignee | ||
Updated•6 years ago
|
status-firefox62:
--- → fix-optional
Updated•6 years ago
|
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•6 years ago
|
Version: Firefox 59 → 59 Branch
Updated•6 years ago
|
Target Milestone: Firefox 63 → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•