It doesn't work right now and causes hangs if you try to use it.

Comment on attachment 8984608 [details] Bug 1467921 - Disable Web Push in GeckoView https://reviewboard.mozilla.org/r/250492/#review256940

Assigning this bug to James because he's already working on it.

Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f55e78d65936 Disable Web Push in GeckoView r=jchen

Backed out for xpcshell failures Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f39774d8f1f37814824016ee716846edae4df5 Push link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f55e78d6593656aff9f61a684bfbc7ba1f3ce264 Log link1: https://treeherder.mozilla.org/logviewer.html#?job_id=185433695&repo=mozilla-inbound&lineNumber=1885 Log link2: https://treeherder.mozilla.org/logviewer.html#?job_id=185430765&repo=mozilla-inbound&lineNumber=2065

Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8bf2b990c788 Disable Web Push in GeckoView r=jchen

James is this something we should uplift to beta or can we just let it ride the trains?

We need to uplift.

Comment on attachment 8984608 [details] Bug 1467921 - Disable Web Push in GeckoView Approval Request Comment [Feature/Bug causing the regression]: GeckoView [User impact if declined]: Hangs in GeckoView [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: There isn't really a Nightly [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: Bug 1467919 [Is the change risky?]: No [Why is the change risky/not risky?]: Only changes a pref for GeckoView [String changes made/needed]: None

Can you request uplift in bug 1467919 too? Thanks!

Comment on attachment 8984608 [details] Bug 1467921 - Disable Web Push in GeckoView Should only affect GeckoView, let's uplift for beta 7.