See bug 1466112. Let's start with JSObject::global().

For now this just forwards to JSObject::global, but at some point it will forward to nonCCWGlobal()/maybeGlobal() or something.

Some places call environment->global() but could just use cx->global() or script->global() instead.

GetInitialShapeProtoKey is only interested in certain builtin NativeObject protos, so let's just check for that. Then we can also just use NativeObject::global.

This lets us call obj->zone() instead of obj->global().

At this point there are a handful of JSObject::global calls left in some APIs and Debugger code. These need to be fixed/audited in follow-up bugs so this renames JSObject::global to deprecatedGlobal.

Comment on attachment 8985072 [details] [diff] [review] Part 8 - Rename JSObject::global to deprecatedGlobal Review of attachment 8985072 [details] [diff] [review]: ----------------------------------------------------------------- Great idea with the explicit deprecation

Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/671e4d24c511 part 1 - Define NativeObject::global(). r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/09901c91248b part 2 - Rename GetOriginalEval to GetRealmOriginalEval, remove scope argument. r=evilpie https://hg.mozilla.org/integration/mozilla-inbound/rev/4face648a152 part 3 - Remove some environment->global() calls. r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/3d767ed287af part 4 - Add JSObject::nonCCWGlobal() and use it in a few places. r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c6358496ff part 5 - Check for native objects in GetInitialShapeProtoKey. r=jwalden https://hg.mozilla.org/integration/mozilla-inbound/rev/d2931773b28b part 6 - Use isSelfHostingZone instead of isSelfHostingGlobal in getNonWrapperObjectForCurrentCompartment. r=evilpie https://hg.mozilla.org/integration/mozilla-inbound/rev/5a19b871c590 part 7 - Replace more environment->global() calls. r=luke https://hg.mozilla.org/integration/mozilla-inbound/rev/fc2ffbc36c07 part 8 - Rename JSObject::global to deprecatedGlobal. r=luke

https://hg.mozilla.org/mozilla-central/rev/671e4d24c511 https://hg.mozilla.org/mozilla-central/rev/09901c91248b https://hg.mozilla.org/mozilla-central/rev/4face648a152 https://hg.mozilla.org/mozilla-central/rev/3d767ed287af https://hg.mozilla.org/mozilla-central/rev/e9c6358496ff https://hg.mozilla.org/mozilla-central/rev/d2931773b28b https://hg.mozilla.org/mozilla-central/rev/5a19b871c590 https://hg.mozilla.org/mozilla-central/rev/fc2ffbc36c07