Closed
Bug 1468654
Opened 6 years ago
Closed 5 years ago
Firefox 60.0.2 not rendering columns in list correctly
Categories
(Core :: Layout, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla70
People
(Reporter: bd.edelman, Assigned: dbaron)
References
(Regression, )
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
image/png
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
Steps to reproduce:
I have a ul to which I am applying columns: 3 to. Each li has an input/custom label. The custom label has the following relevant css. Note the custom label checkbox is being made with FontAwesome5
input[type="checkbox"] + label:before {
content: '';
display: block;
width: 16px;
height: 16px;
border: 1px solid black;
border-radius: 2px;
position: absolute;
background-color: white;
left: 0;
top: 5px;
}
Actual results:
The height 16px is still being applied to the element, but is actually getting rendered as over 18px when I inspect the element. All others are exactly 16px. This only seems to happen at the top of the last column. If I go in to the inspector and click on the height to disable it and then reenable it, it renders perfectly. Have tried adding !important (god help us) to the height, and adding a min-height.
Expected results:
No visual bug on the last column should appear.
Comment 1•6 years ago
|
||
Could you please attach a self-contained minimal testcase as HTML including CSS? Thanks.
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
I can reproduce the layout problem on Windows10 Noghtly62.0a1 x64. And this has been regressed since 56.
status-firefox60:
--- → affected
status-firefox61:
--- → affected
status-firefox62:
--- → affected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → affected
Component: Untriaged → Layout
Keywords: regression
Product: Firefox → Core
Version: 60 Branch → 56 Branch
Updated•6 years ago
|
OS: Unspecified → All
Comment 3•6 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e6e712904806da25a9c8f48ea4533abe7c6ea8f4&tochange=d6bf703c5deaf1e328babd03d5e68ff2a4ffe10e
Via local build,
Last good : 395b6c53e42b
First bad : 1e3130e96f03
Regressed by: 1e3130e96f03 L. David Baron — Bug 1308876 - Mark child frames as dirty before starting reflow of the parent, so that if we reflow a child twice, it's only dirty the first time. r=dholbert
Updated•6 years ago
|
Updated•6 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Current steps to reproduce seem to be to check the "PC Exhibition Prep" checkbox at the bottom of the first column of https://codepen.io/bedelman851/pen/oyWpGq , and then the columns move around and I see the glitch at the top of the third column.
Assignee | ||
Comment 5•5 years ago
|
||
Appears to be fixed by the patches in bug 1420528.
Depends on: 1420528
Assignee | ||
Comment 6•5 years ago
|
||
Will be fixed by bug 1420528.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•5 years ago
|
||
Fixed by landing of bug 1420528.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Updated•5 years ago
|
Updated•5 years ago
|
Flags: qe-verify+
Comment 8•5 years ago
|
||
I have reproduced this issue using Firefox 62.0a1 (2018.06.13) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 70.0b9 on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.13.6.
Flags: qe-verify+
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•