Closed
Bug 1468828
Opened 6 years ago
Closed 6 years ago
automatically copy headers when performing special "hidden" internal redirect to InterceptedHttpChannel
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 1 obsolete file)
In e10s mode with parent-side intercept enabled we currently do a special internal redirect to the InterceptedHttpChannel. This redirect is "hidden" from the child process to avoid confusing the legacy child-side intercept code. An unfortunate consequence of this is that redirect handlers, like fetch API's, cannot do things like copy headers over to the new channel.
We should work around this by copying the headers over automatically for this one special redirect case. Eventually this can be removed when the child-side intercept code is removed and the redirect is unhidden.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8985472 -
Attachment is obsolete: true
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8985631 [details] [diff] [review]
Automatically copy headers to the InterceptedHttpChannel when performing the special hidden internal redirect. r=valentin
This patch copies non-standard headers to the InterceptedHttpChannel when do the special interception redirect in parent-side intercept mode. Please see the comment in the patch for a longer explanation.
Attachment #8985631 -
Flags: review?(valentin.gosu)
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Attachment #8985631 -
Flags: review?(valentin.gosu) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5ee1692bd3c
Automatically copy headers to the InterceptedHttpChannel when performing the special hidden internal redirect. r=valentin
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•