The sideloading indicator used to be orange but it has turned black. It looks like perhaps this rule is inadvertently propagating to the badge? https://searchfox.org/mozilla-central/rev/42930ab9634ebf3f62aed60f7d1c1bf25c0bf00c/browser/themes/shared/toolbarbutton-icons.inc.css#18

Jared can you take a look?

Tim, I thought https://hg.mozilla.org/mozilla-central/rev/0beab09f8058#l6.15 was supposed to handle this?

Specifically, the fallbacks in `fill="context-fill #FFBF00" stroke="context-stroke #fff"`.

Oh, nevermind, yeah the link that Andrew posted is what is setting the fill instead of the fallback color getting used. I'll write up a patch.

Comment on attachment 8985544 [details] Bug 1468864 - Set the fill and stroke for warning.svg in a few places that inherit fill and stroke colors on from toolbarbuttons. https://reviewboard.mozilla.org/r/251156/#review257444 ::: browser/themes/shared/customizableui/panelUI.inc.css:95 (Diff revision 1) > + -moz-context-properties: fill, stroke; > + fill: #FFBF00; > + stroke: #fff; -moz-context-properties: none; should just work instead of redefining the fallbacks already in the SVG ::: browser/themes/shared/customizableui/panelUI.inc.css:453 (Diff revision 1) > + -moz-context-properties: fill, stroke; > + fill: #FFBF00; > + stroke: #fff; > } > > :root[lwt-popup-brighttext] .addon-banner-item::after { > - -moz-context-properties: fill, stroke; Is this change needed ?

Comment on attachment 8985544 [details] Bug 1468864 - Set the fill and stroke for warning.svg in a few places that inherit fill and stroke colors on from toolbarbuttons. https://reviewboard.mozilla.org/r/251156/#review257598 ::: browser/themes/shared/customizableui/panelUI.inc.css:94 (Diff revision 2) > background: transparent url(chrome://browser/skin/warning.svg) no-repeat center; > + background-size: contain; Please move this to the shorthand. ::: browser/themes/shared/customizableui/panelUI.inc.css:98 (Diff revision 2) > height: 13px; > background: transparent url(chrome://browser/skin/warning.svg) no-repeat center; > + background-size: contain; > + box-shadow: none; > + border-radius: 0; > + -moz-context-properties: none; Please add a comment explaining this.

Comment on attachment 8985544 [details] Bug 1468864 - Set the fill and stroke for warning.svg in a few places that inherit fill and stroke colors on from toolbarbuttons. https://reviewboard.mozilla.org/r/251156/#review258002

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f33185af8502 Set the fill and stroke for warning.svg in a few places that inherit fill and stroke colors on from toolbarbuttons. r=ntim

Issue reproduced in Firefox 62.0a1 (20180614220111). Retested and verified in Firefox 62.0a1 (20180621220127) on Windows 10 64Bit, MacOS 10.13.4.