Closed
Bug 1469019
Opened 6 years ago
Closed 6 years ago
Implement Object.fromEntries
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
peterv
:
review+
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Attachment #8985674 -
Attachment description: Implement Object.fromEntries → Implement Object.fromEntries (WIP patch, no tests)
Updated•6 years ago
|
Keywords: dev-doc-needed
Updated•6 years ago
|
Blocks: es-proposals-stage-2
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Attachment #8985674 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #9001282 -
Flags: review?(evilpies)
Comment 4•6 years ago
|
||
Comment on attachment 9001282 [details] [diff] [review]
Object.fromEntries
Review of attachment 9001282 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/builtin/Object.js
@@ +293,5 @@
> + // We omit the usual step number comments here because they don't help.
> + // This implementation inlines AddEntriesFromIterator and
> + // CreateDataPropertyOnObject, so it looks more like the polyfill
> + // <https://github.com/tc39/proposal-object-from-entries/blob/master/polyfill.js>
> + // than the spec algorithm.
I agree.
Attachment #9001282 -
Flags: review?(evilpies) → review+
hooray! code LGTM too. what's the likely soonest this might ride a release train?
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9001282 [details] [diff] [review]
Object.fromEntries
Review of attachment 9001282 [details] [diff] [review]:
-----------------------------------------------------------------
Andrew: Pursuant to js/xpconnect/tests/chrome/test_xrayToJS.xul,
A property on the Object constructor has changed! You need a security audit from an XPConnect peer
which is you. This seems hardly necessary in this case, but why not.
Attachment #9001282 -
Flags: review?(continuation)
Assignee | ||
Comment 8•6 years ago
|
||
Attachment #9001762 -
Flags: review?(continuation)
Assignee | ||
Updated•6 years ago
|
Attachment #9001282 -
Attachment is obsolete: true
Attachment #9001282 -
Flags: review?(continuation)
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries
Carrying forward evilpie's review.
Attachment #9001762 -
Flags: review+
Comment 10•6 years ago
|
||
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries
Review of attachment 9001762 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not really qualified to audit Xray stuff. Maybe Peter could review.
Attachment #9001762 -
Flags: review?(continuation) → review?(peterv)
Comment 11•6 years ago
|
||
Comment on attachment 9001762 [details] [diff] [review]
Object.fromEntries
Review of attachment 9001762 [details] [diff] [review]:
-----------------------------------------------------------------
This looks ok to me.
Attachment #9001762 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed3c662bb21dd708601519540c99e939abb12cff
Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
Comment 14•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 15•6 years ago
|
||
Developer release notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/63#JavaScript
New reference page: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/fromEntries
Compat data: https://github.com/mdn/browser-compat-data/pull/2692
Example: https://github.com/mdn/interactive-examples/pull/1127
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•