Closed
Bug 1469048
Opened 6 years ago
Closed 6 years ago
Disable service worker propagation logic when e10s pref is enabled
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: bkelly, Assigned: mrbkap)
References
Details
(Whiteboard: SW-MUST)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
We we are running in the mode where interception and SWM all live in the parent then we do not want to propagate anything to the child process. We should gate all these IPC messages on the pref value and assert that state is not initialized in the child process.
Reporter | ||
Comment 1•6 years ago
|
||
Work-in-progress. I think this actually breaks some tests.
Updated•6 years ago
|
Priority: -- → P2
Reporter | ||
Comment 2•6 years ago
|
||
Attachment #8985709 -
Attachment is obsolete: true
Updated•6 years ago
|
Whiteboard: SW-MUST
Reporter | ||
Comment 3•6 years ago
|
||
Attachment #8986470 -
Attachment is obsolete: true
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8988838 [details] [diff] [review] Disable service worker propagation when e10s pref is enabled. r=mrbkap Blake, this patch disables the ServiceWorkerManager propagation between processes when the e10s pref is flipped. It also adds some DEBUG assertions that ServiceWorkerRegistrationInfo and ServiceWorkerInfo are not created in the child process the pref is flipped. (Maybe these should be diagnostic asserts in the future.)
Attachment #8988838 -
Flags: review?(mrbkap)
Reporter | ||
Updated•6 years ago
|
Assignee: ben → mrbkap
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8988838 [details] [diff] [review] Disable service worker propagation when e10s pref is enabled. r=mrbkap Review of attachment 8988838 [details] [diff] [review]: ----------------------------------------------------------------- I'm not going to be able to read enough code to know with 100% certainty that this patch is complete. I'll trust the assertions and try runs that Ben already did. It shouldn't matter too much in the long run, anyway, as we eventually move away from the service worker manager in the child process completely and nuke that code.
Attachment #8988838 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7a11d459a7f54ecc8b71746ff2810a7bb276692
Assignee | ||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/031986327e4b40f543852f82378dde497128a370 Bug 1469048 Disable service worker propagation when e10s pref is enabled. r=mrbkap
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/031986327e4b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•