Closed
Bug 1469067
Opened 6 years ago
Closed 6 years ago
Build host programs in their final location
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
The "brotli" host program creates a weird interaction with Tup when using clang. We can work around this by just building it in its final location.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → cmanchester
|
||
Comment 1•6 years ago
|
||
FWIW, I looked into why we build this at all and it was turned on in a bug blocking bug 1352595, so presumably glandium intended to use brotli for omni.ja compression at some point.
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8986060 [details]
Bug 1469067 - Build host programs in their final locations rather than copying them to dist/host/bin.
https://reviewboard.mozilla.org/r/251510/#review257996
Looks great to me. The only thing I wasn't able to double-check is the MS_MANIFEST stuff, but the rest works well in both the make and tup backends as far as I can tell.
Attachment #8986060 -
Flags: review+
|
|
||
Updated•6 years ago
|
Attachment #8986060 -
Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33c34fbb0b0d
Build host programs in their final locations rather than copying them to dist/host/bin. r=mshal
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•