Closed
Bug 1469688
Opened 6 years ago
Closed 6 years ago
Allow reordering the precedence of installed language packs
Categories
(Firefox :: Settings UI, enhancement, P2)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 63
People
(Reporter: mstriemer, Assigned: mstriemer)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
(deleted),
text/x-phabricator-request
|
zbraniecki
:
review+
jaws
:
review+
|
Details |
(deleted),
text/x-phabricator-request
|
flod
:
review+
zbraniecki
:
review+
Gijs
:
review+
|
Details |
(deleted),
image/gif
|
Details | |
(deleted),
text/x-phabricator-request
|
Gijs
:
review+
|
Details |
(deleted),
text/x-phabricator-request
|
Gijs
:
review+
|
Details |
When a user has multiple language packs installed they might want to reorder which languages they would like to see. This UI can be quite similar to the webpage languages dialog.
There is a mock for a nicer UI for this, so try to re-use the webpage dialog in a way that they can both be updated later.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mstriemer
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 8Ym7frVSLug
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod
Francesco Lodolo [:flod] has approved the revision.
Attachment #8999312 -
Flags: review+
Comment 5•6 years ago
|
||
Comment on attachment 8999311 [details]
Bug 1469688 - Part 1: Generalize language switching code in prefs r?jaws,zbraniecki
Zibi Braniecki [:gandalf][:zibi] has approved the revision.
Attachment #8999311 -
Flags: review+
Comment 6•6 years ago
|
||
Comment on attachment 8999311 [details]
Bug 1469688 - Part 1: Generalize language switching code in prefs r?jaws,zbraniecki
(away 8/20-8/27) Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #8999311 -
Flags: review+
Comment 7•6 years ago
|
||
Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod
Zibi Braniecki [:gandalf][:zibi] has approved the revision.
Attachment #8999312 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #8999312 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 8•6 years ago
|
||
I've updated based on your comments, Gijs, and managed to remove some of the code. Thanks for the review!
Comment 9•6 years ago
|
||
Comment on attachment 8999312 [details]
Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod
:Gijs (he/him) has approved the revision.
Attachment #8999312 -
Flags: review+
Updated•6 years ago
|
Attachment #8999312 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Attachment #8999312 -
Attachment description: Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?jaws,zbraniecki → Bug 1469688 - Part 2: Allow reordering of browser languages in prefs r?Gijs,zbraniecki,flod
Comment 12•6 years ago
|
||
Comment on attachment 9004696 [details]
Bug 1469688 - Part 3: Maintain the order of browser languages dialog r?Gijs
:Gijs (he/him) has approved the revision.
Attachment #9004696 -
Flags: review+
Comment 13•6 years ago
|
||
Comment on attachment 9004697 [details]
Bug 1469688 - Part 4: Test the browser languages dialog r?Gijs
:Gijs (he/him) has approved the revision.
Attachment #9004697 -
Flags: review+
Comment 14•6 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/505226ad06ab
Part 1: Generalize language switching code in prefs r=jaws,zbraniecki
https://hg.mozilla.org/integration/mozilla-inbound/rev/6edbb5f98d6e
Part 2: Allow reordering of browser languages in prefs r=Gijs,zbraniecki,flod
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcec32bfccff
Part 3: Maintain the order of browser languages dialog r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/55662a7bc29c
Part 4: Test the browser languages dialog r=Gijs
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/505226ad06ab
https://hg.mozilla.org/mozilla-central/rev/6edbb5f98d6e
https://hg.mozilla.org/mozilla-central/rev/bcec32bfccff
https://hg.mozilla.org/mozilla-central/rev/55662a7bc29c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Flags: qe-verify+
Comment 16•6 years ago
|
||
Could you please provide some steps to follow in order to confirm this?
I cannot find the drop-down in the language section, the only button available is to choose the web pages display language.
I have also tried to see if it activates by adding different language packs to the browser, but without success.
Flags: needinfo?(mstriemer)
Comment 17•6 years ago
|
||
@cristian
We have a PI request tracking the whole feature (Cristian Craciun is coordinating), not sure if we need to verify each bug?
The feature is behind the intl.multilingual.enabled flag.
Flags: needinfo?(mstriemer)
Comment 18•6 years ago
|
||
This Is Confirmed as fixed in Firefox 64.0, Nightly 66 and Beta 65.0b6.
Status: RESOLVED → VERIFIED
status-firefox64:
--- → verified
status-firefox65:
--- → verified
status-firefox66:
--- → verified
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•