Closed Bug 1470068 Opened 6 years ago Closed 6 years ago

Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES

Categories

(Toolkit :: Add-ons Manager, enhancement, P2)

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES.
(deleted), text/x-review-board-request
cpearce
: review+
Details
(In reply to Chris Pearce (:cpearce) from bug 1467700 comment #11) > (In reply to Henrik Skupin (:whimboo) from comment #7) > > (In reply to Henrik Skupin (:whimboo) from comment #6) > > > For EME plugins we basically need another pref which is `media.eme.enabled`. > > > > Interesting that the addon manager repository lists all of the above > > mentioned plugins as EME: > > > > https://dxr.mozilla.org/mozilla-central/rev/ > > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/ > > ProductAddonChecker.jsm#9-15 > > This list is to provide a download location in the case where we can't > connect to the GMP update server/AUS to get the latest list of GMP/CDM > download locations. OpenH264 is not an EME plugin, so I think this list is > misleadingly named; it's deliberately supposed to include both Widevine and > OpenH264, and only one of those in an EME plugin. > > > > So why does disabling EME not also disable the openh264 plugin? Also I can > > set "media.gmp-manager.url.override" to an empty string or > > "media.gmp-gmpopenh264.enabled" to false, but Firefox always downloads this > > plugin. > > OpenH264 is not an EME plugin, so it shouldn't be disabled when EME is > disabled. OpenH264 is used by WebRTC, not EME. > > If the download of the plugin list from AUS fails, we'll use the > LOCAL_EME_SOURCES list to find a location to download the plugin from. (AUS > was down for 3 weeks once, and that stopped new installs of Firefox from > being able to play Netflix, which is why we have this fallback path for > GMP/CDM downloads). > > > > There is something really wrong here in Firefox I assume. Personally I would > > only expect to have to set `media.eme.enabled` to `false` to stop all > > downloads. But as it looks like it is `media.gmp-manager.updateEnabled` > > which has to be set: > > > > https://dxr.mozilla.org/mozilla-central/rev/ > > 75a32b57132f8cba42779555662a057a0416a313/toolkit/mozapps/extensions/internal/ > > ProductAddonChecker.jsm#231-234 > > > > Stephen, maybe you could have another look? Let me know if I should file a > > bug for Firefox. Thanks. > > Based on a quick look at the AddonChecker code, it seems that > media.gmp-manager.updateEnabled is what you need to set. So I think your > patch is the right approach. > > I think the only thing wrong here is that LOCAL_EME_SOURCES is misleadingly > named. I think it would be a good idea to rename it to LOCAL_GMP_SOURCES (or > somesuch) while you're here to clear up future confusion.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8986667 [details] Bug 1470068 - Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. https://reviewboard.mozilla.org/r/251972/#review258418
Attachment #8986667 - Flags: review?(cpearce) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dff46afaa69c Rename LOCAL_EME_SOURCES in ProductAddonChecker to LOCAL_GMP_SOURCES. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/dff46afaa69c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: