Closed Bug 1470396 Opened 6 years ago Closed 6 years ago

Update to source-map to latest version?

Categories

(DevTools :: Framework, enhancement, P2)

Product:
DevTools
Component:
Framework
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Unassigned)

References

(Blocks 1 open bug)

Details

I've just landed https://github.com/mozilla/source-map/pull/347 into source-map which updates the tests included within it to provide the expected arguments for Assert.throws/rejects - something that bug 1452706 is working on to become required by default. Could we update the mozilla-central version of source-map to the latest version to pick up these changes, rather than patching? There are some breaking changes: https://github.com/mozilla/source-map/blob/master/CHANGELOG.md Also there seems to be an issue with the tests in the repository which aren't generated into dist as the current upgrading documentation suggests: https://github.com/mozilla/source-map/issues/348
Blocks: source-maps
Hello! Thanks for filing the issue. Quick update regarding this: We have a patch that is in progress from a little while ago and will be picked up again in the next week: https://github.com/devtools-html/devtools-core/pull/995/commits/1ed76bbd278ddb0ccc6b98ec3aeeed404e291a7a
Assignee: nobody → ystartsev
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P2

This bug has not been updated in the last 6 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.

Assignee: ystartsev → nobody
Status: ASSIGNED → NEW

It looks like this is resolved here : https://github.com/firefox-devtools/debugger/pull/7071

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.