Closed
Bug 1470552
Opened 6 years ago
Closed 6 years ago
Update Makefile.in attempting to add a dependency on a GENERATED_FILES target
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
Bug 1454912 changed the actual target for all GENERATED_FILES. We have a hack in the root Makefile.in to ensure we re-generate the buildid in certain circumstances, which references the actual file rather the stub target, so it no longer works.
Comment hidden (mozreview-request) |
Updated•6 years ago
|
Attachment #8987181 -
Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8987181 [details]
Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk
https://reviewboard.mozilla.org/r/252424/#review258934
Doh!
Attachment #8987181 -
Flags: review?(nfroyd) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/567df8598cdb
Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf56c04574dd
Backed out 1 changesets for build bustages mozbuild/test/backend/test_build.py CLOSED TREE
Comment 5•6 years ago
|
||
Backed out 1 changesets (bug 1470552) for build bustages mozbuild/test/backend/test_build.py
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=567df8598cdb89ab9869c5d664db131499adf5b5&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable
failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=567df8598cdb89ab9869c5d664db131499adf5b5&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=184432271&filter-searchStr=Linux+debug+build-linux%2Fdebug+%28B%29
log: https://treeherder.mozilla.org/logviewer.html#?job_id=184432271&repo=autoland
backout: https://hg.mozilla.org/integration/autoland/rev/bf56c04574dd2e91f2bdcfc3c901bf2ebbae904f
Flags: needinfo?(cmanchester)
Assignee | ||
Comment 6•6 years ago
|
||
This test is pretty brittle. Fix incoming.
Flags: needinfo?(cmanchester)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dbc843c1429
Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj
Comment 10•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•