Closed Bug 1470709 Opened 6 years ago Closed 5 years ago

GeckoView uses variables from UA sheets, which are exposed to content.

Categories

(GeckoView :: General, defect, P3)

Product:
GeckoView
Component:
General
Type:
defect

Tracking

(firefox62 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 wontfix, firefox66 wontfix, firefox75 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox75 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

Testcase (should be blank, prints #bfbfbf on nightly fennec)
(deleted), text/html
Details
Bug 1470709 - Stop using CSS variables from android UA stylesheets. r=snorp
(deleted), text/x-phabricator-request
Details
The fact that rules like[1] are loaded into content is observable, and someone could start relying on it. Also, variables are a bit slower, but that's not quite the point. [1]: https://searchfox.org/mozilla-central/rev/9a3f8590f807d449e790c8ba0e39eb14f41066d8/mobile/android/themes/geckoview/defines.css#6
Summary: Gecko view uses variables from UA sheets, which are exposed to content. → GeckoView uses variables from UA sheets, which are exposed to content.
Attachment #8987306 - Attachment description: Testcase (should be blank, prints #bfbfbf on nightly) → Testcase (should be blank, prints #bfbfbf on nightly fennec)
Attachment #8987306 - Attachment mime type: text/plain → text/html
Does this bug affect both Fennec Nightly and Focus+GeckoView Nightly? Comment 0 mentions Fennec Nightly, but the stylesheet is in a geckoview directory.
status-firefox62: --- → wontfix
status-firefox63: --- → fix-optional
Priority: -- → P3
Affects both.
Depends on: 1208759
Blocks: 1208759
No longer depends on: 1208759
Product: Firefox for Android → GeckoView
Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.
status-firefox65: affected → fix-optional
status-firefox66: --- → fix-optional
Blocks: 1618202

Just inline them, they're not that many.

Using CSS variables is observable from content, which is not good. It also means
that we need an @import.

For bug 1618202, I plan to move this stylesheet to the global stylesheet cache.

This is so that I can add them based on prefs, but should also have memory
improvements (the stylesheet would be shared in memory across processes, see bug
1474793).

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7249f7406387 Stop using CSS variables from android UA stylesheets. r=snorp

https://hg.mozilla.org/mozilla-central/rev/7249f7406387

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: