Closed Bug 1470977 Opened 6 years ago Closed 6 years ago

Fix GLBlitHelperD3D.cpp mingw clang compilation

Categories

(Core :: Graphics, defect, P2)

Product:
Core
Component:
Graphics
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1470977 - Fix GLBlitHelperD3D.cpp mingw clang compilation
(deleted), text/x-review-board-request
lsalzman
: review+
RyanVM
: approval-mozilla-esr60+
Details
It fails with: 0:18.70 In file included from /mnt/build/mozilla/gecko/obj-x86_64-w64-mingw32/gfx/gl/Unified_cpp_gfx_gl0.cpp:38: 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:192:10: error: case value is not a constant expression 0:18.70 case subdescUnion.TSurfaceDescriptorDXGIYCbCr: 0:18.70 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:192:10: note: initializer of 'subdescUnion' is not a constant expression 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:185:17: note: declared here 0:18.70 const auto& subdescUnion = desc.subdesc(); 0:18.70 ^ 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:187:10: error: case value is not a constant expression 0:18.70 case subdescUnion.TSurfaceDescriptorD3D10: 0:18.70 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:187:10: note: initializer of 'subdescUnion' is not a constant expression 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:185:17: note: declared here 0:18.70 const auto& subdescUnion = desc.subdesc(); 0:18.70 ^ 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:227:17: warning: unused variable 'clipRect' [-Wunused-variable] 0:18.70 const auto& clipRect = srcImage->mPictureRect; 0:18.70 ^ 0:18.70 /mnt/build/mozilla/gecko/gfx/gl/GLBlitHelperD3D.cpp:228:17: warning: unused variable 'colorSpace' [-Wunused-variable] 0:18.70 const auto& colorSpace = srcImage->mColorSpace;
Comment on attachment 8987915 [details] Bug 1470977 - Fix GLBlitHelperD3D.cpp mingw clang compilation https://reviewboard.mozilla.org/r/253200/#review259780
Attachment #8987915 - Flags: review?(lsalzman) → review+
Thanks for review. This works on msvc as well, so I will push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9e3a2d24ac5b87436160f999c42b7a978f0d25a
Pushed by jacek@codeweavers.com: https://hg.mozilla.org/integration/autoland/rev/e79176a9ffcb Fix GLBlitHelperD3D.cpp mingw clang compilation r=lsalzman
Assignee: nobody → jacek
Comment on attachment 8987915 [details] Bug 1470977 - Fix GLBlitHelperD3D.cpp mingw clang compilation [Approval Request Comment] This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60. This commit affects all builds, but if it causes any problems the build will not compile.
Attachment #8987915 - Flags: approval-mozilla-esr60?
https://hg.mozilla.org/integration/autoland/rev/4b0113139f3dfc004077edefc83b3187f605e0e5 Log: https://treeherder.mozilla.org/logviewer.html#?job_id=185197450&repo=autoland&lineNumber=6616 | --DOMWINDOW == 33 (000001F718935E00) [pid = 5160] [serial = 998] [outer = 0000000000000000] [url = http://mochi.test:8888/tests/dom/canvas/test/webgl-conf/checkout/conformance2/textures/misc/gl-get-tex-parameter.html?webglVersion=2] 16:20:54 INFO - GECKO(5712) | [GFX1]: Unhandled subdesc type: 1 16:20:54 INFO - GECKO(5712) | Assertion failure: [GFX1]: Unhandled subdesc type: 1, at z:\build\build\src\obj-firefox\dist\include\mozilla/gfx/Logging.h:727 16:20:54 INFO - GECKO(5712) | #01: mozilla::gl::GLBlitHelper::BlitImage(mozilla::layers::GPUVideoImage *,mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const &,mozilla::gl::OriginPos) [gfx/gl/GLBlitHelperD3D.cpp:212] 16:20:54 INFO - GECKO(5712) | #02: mozilla::gl::GLBlitHelper::BlitImageToFramebuffer(mozilla::layers::Image *,mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const &,mozilla::gl::OriginPos) [gfx/gl/GLBlitHelper.cpp:743] 16:20:54 INFO - GECKO(5712) | #03: mozilla::webgl::TexUnpackImage::TexOrSubImage(bool,bool,char const *,mozilla::WebGLTexture *,StrongGLenum<TexImageTargetDetails>,int,mozilla::webgl::DriverUnpackInfo const *,int,int,int,mozilla::webgl::PackingInfo const &,unsigned int * const) [dom/canvas/TexUnpackBlob.cpp:707] 16:20:54 INFO - GECKO(5712) | #04: mozilla::WebGLTexture::TexImage(char const *,StrongGLenum<TexImageTargetDetails>,int,unsigned int,mozilla::webgl::PackingInfo const &,mozilla::webgl::TexUnpackBlob const *) [dom/canvas/WebGLTextureUpload.cpp:1295] 16:20:54 INFO - GECKO(5712) | #05: mozilla::WebGLTexture::TexImage(char const *,StrongGLenum<TexImageTargetDetails>,int,unsigned int,int,int,int,int,mozilla::webgl::PackingInfo const &,mozilla::TexImageSource const &) [dom/canvas/WebGLTextureUpload.cpp:479] 16:20:54 INFO - GECKO(5712) | #06: mozilla::WebGLContext::TexImage(char const *,unsigned char,unsigned int,int,unsigned int,int,int,int,int,unsigned int,unsigned int,mozilla::TexImageSource const &) [dom/canvas/WebGLContextTextures.cpp:393] 16:20:54 INFO - GECKO(5712) | #07: mozilla::WebGLContext::TexImage2D(unsigned int,int,unsigned int,int,int,int,unsigned int,unsigned int,mozilla::TexImageSource const &) [dom/canvas/WebGLContext.h:1216] 16:20:54 INFO - GECKO(5712) | #08: mozilla::WebGLContext::TexImage2D<mozilla::dom::HTMLVideoElement>(unsigned int,int,unsigned int,int,int,int,unsigned int,unsigned int,mozilla::dom::HTMLVideoElement const &,mozilla::ErrorResult &) [dom/canvas/WebGLContext.h:1194] 16:20:54 INFO - GECKO(5712) | #09: static bool mozilla::dom::WebGL2RenderingContext_Binding::texImage2D(struct JSContext *, class JS::Handle<JSObject *>, class mozilla::WebGL2Context *, const class JSJitMethodCallArgs & const) [s3:gecko-generated-sources:ee10d73b6435fc28e37a650fb48cc2a2e5a498e93e75fa7fe1f7e716236d61a2781b077a5f6e42731b63cd32267db2696f7b44d9f003baacd319fb4ad82adc3a/dom/bindings/WebGL2RenderingContextBinding.cpp::1502] 16:20:54 INFO - GECKO(5712) | #10: mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext *,unsigned int,JS::Value *) [dom/bindings/BindingUtils.cpp:3285] 16:20:54 INFO - GECKO(5712) | #11: CallJSNative(JSContext *,bool (*)(JSContext *,unsigned int,JS::Value *),JS::CallArgs const &) [js/src/vm/Interpreter.cpp:440] 16:20:54 INFO - GECKO(5712) | #12: js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [js/src/vm/Interpreter.cpp:529] 16:20:54 INFO - GECKO(5712) | #13: static bool Interpret(struct JSContext *, class js::RunState & const) [js/src/vm/Interpreter.cpp:3190] 16:20:54 INFO - GECKO(5712) | #14: js::RunScript(JSContext *,js::RunState &) [js/src/vm/Interpreter.cpp:423] 16:20:54 INFO - GECKO(5712) | #15: js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [js/src/vm/Interpreter.cpp:553] 16:20:54 INFO - GECKO(5712) | #16: js::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,js::AnyInvokeArgs const &,JS::MutableHandle<JS::Value>) [js/src/vm/Interpreter.cpp:599] 16:20:54 INFO - GECKO(5712) | #17: JS::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,JS::HandleValueArray const &,JS::MutableHandle<JS::Value>) [js/src/jsapi.cpp:2887] 16:20:54 INFO - GECKO(5712) | #18: mozilla::dom::EventListener::HandleEvent(JSContext *,JS::Handle<JS::Value>,mozilla::dom::Event &,mozilla::ErrorResult &) [s3:gecko-generated-sources:e816b4f4f30964385620ba830df06fdcd39d446fe1fdffff6456b871436a3b901a23e2e240dd3c827e111854955736f133baf4e40d20f3f3ee0075460dab9d70/dom/bindings/EventListenerBinding.cpp::51] 16:20:54 INFO - GECKO(5712) | #19: mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget *>(mozilla::dom::EventTarget * const &,mozilla::dom::Event &,mozilla::ErrorResult &,char const *,mozilla::dom::CallbackObject::ExceptionHandling,JS::Realm *) [s3:gecko-generated-sources:0384e79ee46ca9f3c4b5ade264338740634b9529012db1cbefa8f7a8aafcc2af6d8a1f96ff257b6fd363a30f1422945345b4a0b732edad9041457a263bf3ac41/dist/include/mozilla/dom/EventListenerBinding.h::66] 16:20:54 INFO - GECKO(5712) | #20: mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener *,mozilla::dom::Event *,mozilla::dom::EventTarget *) [dom/events/EventListenerManager.cpp:1122] 16:20:54 INFO - GECKO(5712) | #21: mozilla::EventListenerManager::HandleEventInternal(nsPresContext *,mozilla::WidgetEvent *,mozilla::dom::Event * *,mozilla::dom::EventTarget *,nsEventStatus *) [dom/events/EventListenerManager.cpp:1298] 16:20:54 INFO - GECKO(5712) | #22: mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor &,mozilla::ELMCreationDetector &) [dom/events/EventDispatcher.cpp:408] 16:20:54 INFO - GECKO(5712) | #23: mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem> &,mozilla::EventChainPostVisitor &,mozilla::EventDispatchingCallback *,mozilla::ELMCreationDetector &) [dom/events/EventDispatcher.cpp:622] 16:20:54 INFO - GECKO(5712) | #24: mozilla::EventDispatcher::Dispatch(nsISupports *,nsPresContext *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsEventStatus *,mozilla::EventDispatchingCallback *,nsTArray<mozilla::dom::EventTarget *> *) [dom/events/EventDispatcher.cpp:1094] 16:20:54 INFO - GECKO(5712) | #25: mozilla::EventDispatcher::DispatchDOMEvent(nsISupports *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsPresContext *,nsEventStatus *) [dom/events/EventDispatcher.cpp:1168] 16:20:54 INFO - GECKO(5712) | #26: nsINode::DispatchEvent(mozilla::dom::Event &,mozilla::dom::CallerType,mozilla::ErrorResult &) [dom/base/nsINode.cpp:1089] 16:20:54 INFO - GECKO(5712) | #27: nsContentUtils::DispatchEvent(nsIDocument *,nsISupports *,nsTSubstring<char16_t> const &,mozilla::CanBubble,mozilla::Cancelable,mozilla::Trusted,bool *,mozilla::ChromeOnlyDispatch) [dom/base/nsContentUtils.cpp:4497] 16:20:54 INFO - GECKO(5712) | #28: nsContentUtils::DispatchTrustedEvent(nsIDocument *,nsISupports *,nsTSubstring<char16_t> const &,mozilla::CanBubble,mozilla::Cancelable,bool *) [dom/base/nsContentUtils.cpp:4462] 16:20:54 INFO - GECKO(5712) | #29: mozilla::dom::HTMLMediaElement::DispatchEvent(nsTSubstring<char16_t> const &) [dom/html/HTMLMediaElement.cpp:6314] 16:20:54 INFO - GECKO(5712) | #30: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:341] 16:20:54 INFO - GECKO(5712) | #31: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1054] 16:20:54 INFO - GECKO(5712) | #32: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:519] 16:20:54 INFO - GECKO(5712) | #33: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:97] 16:20:54 INFO - GECKO(5712) | #34: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:301] 16:20:54 INFO - GECKO(5712) | #35: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:319] 16:20:54 INFO - GECKO(5712) | #36: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:299] 16:20:54 INFO - GECKO(5712) | #37: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:160] 16:20:54 INFO - GECKO(5712) | #38: nsAppShell::Run() [widget/windows/nsAppShell.cpp:417] 16:20:54 INFO - GECKO(5712) | #39: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:896] 16:20:54 INFO - GECKO(5712) | #40: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:269] 16:20:54 INFO - GECKO(5712) | #41: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:319] 16:20:54 INFO - GECKO(5712) | #42: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:299] 16:20:54 INFO - GECKO(5712) | #43: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:726] 16:20:54 INFO - GECKO(5712) | #44: content_process_main(mozilla::Bootstrap *,int,char * * const) [ipc/contentproc/plugin-container.cpp:51] 16:20:54 INFO - GECKO(5712) | #45: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:290] 16:20:54 INFO - GECKO(5712) | #46: wmain [toolkit/xre/nsWindowsWMain.cpp:143] 16:20:54 INFO - GECKO(5712) | #47: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:283] 16:20:54 INFO - GECKO(5712) | #48: KERNEL32.DLL + 0x12774 16:20:54 INFO - GECKO(5712) | #49: ntdll.dll + 0x70d51 16:20:54 INFO - GECKO(5712) | Hit MOZ_CRASH(GFX: An assert from the graphics logger) at z:\build\build\src\obj-firefox\dist\include\mozilla/gfx/Logging.h:728 16:20:54 INFO - GECKO(5712) | #01: mozilla::gl::GLBlitHelper::BlitImage(mozilla::layers::GPUVideoImage *,mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const &,mozilla::gl::OriginPos) [gfx/gl/GLBlitHelperD3D.cpp:212] 16:20:54 INFO - GECKO(5712) | #02: mozilla::gl::GLBlitHelper::BlitImageToFramebuffer(mozilla::layers::Image *,mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const &,mozilla::gl::OriginPos) [gfx/gl/GLBlitHelper.cpp:743] 16:20:54 INFO - GECKO(5712) | #03: mozilla::webgl::TexUnpackImage::TexOrSubImage(bool,bool,char const *,mozilla::WebGLTexture *,StrongGLenum<TexImageTargetDetails>,int,mozilla::webgl::DriverUnpackInfo const *,int,int,int,mozilla::webgl::PackingInfo const &,unsigned int * const) [dom/canvas/TexUnpackBlob.cpp:707] 16:20:54 INFO - GECKO(5712) | #04: mozilla::WebGLTexture::TexImage(char const *,StrongGLenum<TexImageTargetDetails>,int,unsigned int,mozilla::webgl::PackingInfo const &,mozilla::webgl::TexUnpackBlob const *) [dom/canvas/WebGLTextureUpload.cpp:1295] 16:20:54 INFO - GECKO(5712) | #05: mozilla::WebGLTexture::TexImage(char const *,StrongGLenum<TexImageTargetDetails>,int,unsigned int,int,int,int,int,mozilla::webgl::PackingInfo const &,mozilla::TexImageSource const &) [dom/canvas/WebGLTextureUpload.cpp:479] 16:20:54 INFO - GECKO(5712) | #06: mozilla::WebGLContext::TexImage(char const *,unsigned char,unsigned int,int,unsigned int,int,int,int,int,unsigned int,unsigned int,mozilla::TexImageSource const &) [dom/canvas/WebGLContextTextures.cpp:393] 16:20:54 INFO - GECKO(5712) | #07: mozilla::WebGLContext::TexImage2D(unsigned int,int,unsigned int,int,int,int,unsigned int,unsigned int,mozilla::TexImageSource const &) [dom/canvas/WebGLContext.h:1216] 16:20:54 INFO - GECKO(5712) | #08: mozilla::WebGLContext::TexImage2D<mozilla::dom::HTMLVideoElement>(unsigned int,int,unsigned int,int,int,int,unsigned int,unsigned int,mozilla::dom::HTMLVideoElement const &,mozilla::ErrorResult &) [dom/canvas/WebGLContext.h:1194] 16:20:54 INFO - GECKO(5712) | #09: static bool mozilla::dom::WebGL2RenderingContext_Binding::texImage2D(struct JSContext *, class JS::Handle<JSObject *>, class mozilla::WebGL2Context *, const class JSJitMethodCallArgs & const) [s3:gecko-generated-sources:ee10d73b6435fc28e37a650fb48cc2a2e5a498e93e75fa7fe1f7e716236d61a2781b077a5f6e42731b63cd32267db2696f7b44d9f003baacd319fb4ad82adc3a/dom/bindings/WebGL2RenderingContextBinding.cpp::1502] 16:20:54 INFO - GECKO(5712) | #10: mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext *,unsigned int,JS::Value *) [dom/bindings/BindingUtils.cpp:3285] 16:20:54 INFO - GECKO(5712) | #11: CallJSNative(JSContext *,bool (*)(JSContext *,unsigned int,JS::Value *),JS::CallArgs const &) [js/src/vm/Interpreter.cpp:440] 16:20:54 INFO - GECKO(5712) | #12: js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [js/src/vm/Interpreter.cpp:529] 16:20:54 INFO - GECKO(5712) | #13: static bool Interpret(struct JSContext *, class js::RunState & const) [js/src/vm/Interpreter.cpp:3190] 16:20:54 INFO - GECKO(5712) | #14: js::RunScript(JSContext *,js::RunState &) [js/src/vm/Interpreter.cpp:423] 16:20:54 INFO - GECKO(5712) | #15: js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [js/src/vm/Interpreter.cpp:553] 16:20:54 INFO - GECKO(5712) | #16: js::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,js::AnyInvokeArgs const &,JS::MutableHandle<JS::Value>) [js/src/vm/Interpreter.cpp:599] 16:20:54 INFO - GECKO(5712) | #17: JS::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,JS::HandleValueArray const &,JS::MutableHandle<JS::Value>) [js/src/jsapi.cpp:2887] 16:20:54 INFO - GECKO(5712) | #18: mozilla::dom::EventListener::HandleEvent(JSContext *,JS::Handle<JS::Value>,mozilla::dom::Event &,mozilla::ErrorResult &) [s3:gecko-generated-sources:e816b4f4f30964385620ba830df06fdcd39d446fe1fdffff6456b871436a3b901a23e2e240dd3c827e111854955736f133baf4e40d20f3f3ee0075460dab9d70/dom/bindings/EventListenerBinding.cpp::51] 16:20:54 INFO - GECKO(5712) | #19: mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget *>(mozilla::dom::EventTarget * const &,mozilla::dom::Event &,mozilla::ErrorResult &,char const *,mozilla::dom::CallbackObject::ExceptionHandling,JS::Realm *) [s3:gecko-generated-sources:0384e79ee46ca9f3c4b5ade264338740634b9529012db1cbefa8f7a8aafcc2af6d8a1f96ff257b6fd363a30f1422945345b4a0b732edad9041457a263bf3ac41/dist/include/mozilla/dom/EventListenerBinding.h::66] 16:20:54 INFO - GECKO(5712) | #20: mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener *,mozilla::dom::Event *,mozilla::dom::EventTarget *) [dom/events/EventListenerManager.cpp:1122] 16:20:54 INFO - GECKO(5712) | #21: mozilla::EventListenerManager::HandleEventInternal(nsPresContext *,mozilla::WidgetEvent *,mozilla::dom::Event * *,mozilla::dom::EventTarget *,nsEventStatus *) [dom/events/EventListenerManager.cpp:1298] 16:20:54 INFO - GECKO(5712) | #22: mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor &,mozilla::ELMCreationDetector &) [dom/events/EventDispatcher.cpp:408] 16:20:54 INFO - GECKO(5712) | #23: mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem> &,mozilla::EventChainPostVisitor &,mozilla::EventDispatchingCallback *,mozilla::ELMCreationDetector &) [dom/events/EventDispatcher.cpp:622] 16:20:54 INFO - GECKO(5712) | #24: mozilla::EventDispatcher::Dispatch(nsISupports *,nsPresContext *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsEventStatus *,mozilla::EventDispatchingCallback *,nsTArray<mozilla::dom::EventTarget *> *) [dom/events/EventDispatcher.cpp:1094] 16:20:54 INFO - GECKO(5712) | #25: mozilla::EventDispatcher::DispatchDOMEvent(nsISupports *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsPresContext *,nsEventStatus *) [dom/events/EventDispatcher.cpp:1168] 16:20:54 INFO - GECKO(5712) | #26: nsINode::DispatchEvent(mozilla::dom::Event &,mozilla::dom::CallerType,mozilla::ErrorResult &) [dom/base/nsINode.cpp:1089] 16:20:54 INFO - GECKO(5712) | #27: nsContentUtils::DispatchEvent(nsIDocument *,nsISupports *,nsTSubstring<char16_t> const &,mozilla::CanBubble,mozilla::Cancelable,mozilla::Trusted,bool *,mozilla::ChromeOnlyDispatch) [dom/base/nsContentUtils.cpp:4497] 16:20:54 INFO - GECKO(5712) | #28: nsContentUtils::DispatchTrustedEvent(nsIDocument *,nsISupports *,nsTSubstring<char16_t> const &,mozilla::CanBubble,mozilla::Cancelable,bool *) [dom/base/nsContentUtils.cpp:4462] 16:20:54 INFO - GECKO(5712) | #29: mozilla::dom::HTMLMediaElement::DispatchEvent(nsTSubstring<char16_t> const &) [dom/html/HTMLMediaElement.cpp:6314] 16:20:54 INFO - GECKO(5712) | #30: mozilla::SchedulerGroup::Runnable::Run() [xpcom/threads/SchedulerGroup.cpp:341] 16:20:54 INFO - GECKO(5712) | #31: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1054] 16:20:54 INFO - GECKO(5712) | #32: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:519] 16:20:54 INFO - GECKO(5712) | #33: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:97] 16:20:54 INFO - GECKO(5712) | #34: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:301] 16:20:54 INFO - GECKO(5712) | #35: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:319] 16:20:54 INFO - GECKO(5712) | #36: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:299] 16:20:54 INFO - GECKO(5712) | #37: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:160] 16:20:54 INFO - GECKO(5712) | #38: nsAppShell::Run() [widget/windows/nsAppShell.cpp:417] 16:20:54 INFO - GECKO(5712) | #39: XRE_RunAppShell() [toolkit/xre/nsEmbedFunctions.cpp:896] 16:20:54 INFO - GECKO(5712) | #40: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:269] 16:20:54 INFO - GECKO(5712) | #41: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:319] 16:20:54 INFO - GECKO(5712) | #42: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:299] 16:20:54 INFO - GECKO(5712) | #43: XRE_InitChildProcess(int,char * * const,XREChildData const *) [toolkit/xre/nsEmbedFunctions.cpp:726] 16:20:54 INFO - GECKO(5712) | #44: content_process_main(mozilla::Bootstrap *,int,char * * const) [ipc/contentproc/plugin-container.cpp:51] 16:20:54 INFO - GECKO(5712) | #45: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:290] 16:20:54 INFO - GECKO(5712) | #46: wmain [toolkit/xre/nsWindowsWMain.cpp:143] 16:20:54 INFO - GECKO(5712) | #47: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:283] 16:20:54 INFO - GECKO(5712) | #48: KERNEL32.DLL + 0x12774 16:20:54 INFO - GECKO(5712) | #49: ntdll.dll + 0x70d51 Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e79176a9ffcb659bd5d8a68d53551b81c5b5fd4a Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e79176a9ffcb659bd5d8a68d53551b81c5b5fd4a
Flags: needinfo?(jacek)
Oops. There are two enums that have a TSurfaceDescriptorD3D10 / TSurfaceDescriptorDXGIYCbCr member. We want this one: https://searchfox.org/mozilla-central/source/__GENERATED__/ipc/ipdl/_ipdlheaders/mozilla/layers/LayersSurfaces.h#1197
Oh, sorry about that. I'm submitting a new version.
Flags: needinfo?(jacek)
It looks like my updated mozreview push didn't handle r? properly. Could you please review the updated version?
Attachment #8987915 - Flags: review+ → review?(lsalzman)
Comment on attachment 8987915 [details] Bug 1470977 - Fix GLBlitHelperD3D.cpp mingw clang compilation https://reviewboard.mozilla.org/r/253200/#review262574
Attachment #8987915 - Flags: review?(lsalzman) → review+
Pushed by jacek@codeweavers.com: https://hg.mozilla.org/integration/autoland/rev/174449936ae0 Fix GLBlitHelperD3D.cpp mingw clang compilation r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/174449936ae0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment on attachment 8987915 [details] Bug 1470977 - Fix GLBlitHelperD3D.cpp mingw clang compilation Makes downstream maintenance easier for Tor. Approved for ESR 60.2.
Attachment #8987915 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: