Closed Bug 1471016 Opened 6 years ago Closed 6 years ago

cubeb_winmm.c should not define __MSVCRT_VERSION__

Categories

(Core :: Audio/Video: cubeb, defect, P5)

Product:
Core
Component:
Audio/Video: cubeb
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox62 --- unaffected
firefox63 --- unaffected

People

(Reporter: jacek, Assigned: jacek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1471016 - cubeb_winmm.c should not define __MSVCRT_VERSION__
(deleted), text/x-review-board-request
padenot
: review+
RyanVM
: approval-mozilla-esr60+
Details
Here is upstream pull request: https://github.com/kinetiknz/cubeb/pull/446 This is a problem for ucrt-based mingw-w64 builds like clang+mingw-w64 from bug 1465790.
Depends on: 1471164
Priority: -- → P5
The patch was merged upstream and merged to m-c in bug 1471164. The attached version is for esr60 backport.
Attachment #8987639 - Flags: review?(padenot)
Comment on attachment 8987639 [details] Bug 1471016 - cubeb_winmm.c should not define __MSVCRT_VERSION__ https://reviewboard.mozilla.org/r/252868/#review262808
Attachment #8987639 - Flags: review?(padenot) → review+
Comment on attachment 8987639 [details] Bug 1471016 - cubeb_winmm.c should not define __MSVCRT_VERSION__ [Approval Request Comment] This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60. This commit affects only MinGW builds, so it is low risk.
Attachment #8987639 - Flags: approval-mozilla-esr60?
Comment on attachment 8987639 [details] Bug 1471016 - cubeb_winmm.c should not define __MSVCRT_VERSION__ Makes downstream maintenance easier for Tor. Already landed on m-c via bug 1471164. Approved for ESR 60.2.
Attachment #8987639 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
https://hg.mozilla.org/releases/mozilla-esr60/rev/9accf16021d1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → unaffected
status-firefox63: --- → unaffected
status-firefox-esr60: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: