Closed
Bug 1471177
Opened 6 years ago
Closed 6 years ago
Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: jacek, Assigned: jacek)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
froydnj
:
review+
RyanVM
:
approval-mozilla-esr60+
|
Details |
clang has its own libc++ implementation, which implements wchat_t functions. This causes problems with mingw clang builds. I think that we should use those only when building against GCC libstdc++.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.
https://reviewboard.mozilla.org/r/253076/#review259654
Attachment #8987797 -
Flags: review?(nfroyd) → review+
Comment 3•6 years ago
|
||
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.
[Approval Request Comment]
This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.
This commit only affects the MinGW build configuration, so it is low-risk.
Attachment #8987797 -
Flags: approval-mozilla-esr60?
Comment hidden (mozreview-request) |
Pushed by jacek@codeweavers.com:
https://hg.mozilla.org/integration/autoland/rev/23fb443b2214
Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++. r=froydnj
Comment 6•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 7•6 years ago
|
||
Comment on attachment 8987797 [details]
Bug 1471177 - Use mingw-specific IFStream and OFStream implementation only when building againstd libstdc++.
Makes downstream maintenance easier for Tor. Approved for ESR 60.2.
Attachment #8987797 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 8•6 years ago
|
||
bugherder uplift |
status-firefox-esr60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•