Ben Kelly [:bkelly, not reviewing] Assignee
	Description • 6 years ago

In bug 1357463 I added CopyableErrorResult to support copying as part of ipdl structures.  I botched the copy constructor and assignment operator method signatures, though.  They need to be const.

Splitting this patch out from bug 1459209.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 2 • 6 years ago

Err, this is about const operator==() actually.  Sorry for wrong description in comment 0.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 3 • 6 years ago

Comment on attachment 8987904 [details] [diff] [review]
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz

Boris, this patch fixes a few things I missed in bug 1357463.  Specifically:

1. The Message and DOMException structures need to have const operator==().
2. TErrorResult<>::operator==() needs to be able to access the Message and DOMException operator==() implementation.  So it needs to move into BindingUtils.cpp.

With these changes CopyableErrorResult compiles in ipdl structures correctly.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 6 years ago

Comment on attachment 8987904 [details] [diff] [review]
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz

r=me

	Pulsebot
	Comment 5 • 6 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0be300394024
Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz

	Tiberius Oros[:tiberius_oros]
	Comment 6 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/0be300394024