Closed Bug 1471460 Opened 6 years ago Closed 6 years ago

Adjust the styles of the active markup display badges

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm glad you suggested I take a look at this in Nightly — I tested out the colors I suggested before and realized they weren't very good because the selected effect wasn't strong enough. Also I had neglected dark mode. So now, I think the changes I would make to the current selected badge style is just to tone down the white border a bit and remove the hover state for selected styles (which currently is a white on gray look). Light mode: border: 1px solid #ffffffb3; Dark mode: border: 1px solid #fff6; Also, it seems to take a bit too much time for the selected styling to appear after I click the badge, which gets a bit confusing. Is there some way to make it appear instantaneous with the click?
Assignee: gl → nobody
Status: ASSIGNED → NEW
Assignee: nobody → gl
Status: NEW → ASSIGNED
Attached patch 1471460.patch (deleted) — Splinter Review
Attachment #9004106 - Flags: review?(mratcliffe)
Attachment #9004106 - Flags: review?(mratcliffe) → review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c09a146819d3 Adjust the styles of the active markup display badges. r=miker
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: