Closed Bug 1471465 Opened 6 years ago Closed 6 years ago

Fix some issues with ungetting LineTerminatorSequence in certain places

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attached patch Patch (deleted) — Splinter Review
I messed up addressing comments in a couple places in bug 1467336, gotta fix 'em. (Recall that getNonAsciiCodePoint normalizes.) The identifier bug is being tested in https://github.com/tc39/test262/pull/1612 so nothing in this patch. The failure-to-undo-line-updates issue is tested in the patch, as lineNumber behavior is not standardized. These are possibly some of the most obscure bugs ever.
Attachment #8988056 - Flags: review?(arai.unmht)
Attachment #8988056 - Flags: review?(arai.unmht) → review+
Blocks: test262
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/26ded9d5d332 Fix some issues with ungetting LineTerminatorSequence in certain places. r=arai
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: