Closed
Bug 1471544
Opened 6 years ago
Closed 6 years ago
Load "menulist.css" as a document stylesheet
Categories
(Toolkit :: Themes, defect, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
This is part of the work tracked in bug 1470830.
Assignee | ||
Comment 1•6 years ago
|
||
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
The rebase landed on a bad revision, let's retry:
Screenshots: https://treeherder.mozilla.org/#/jobs?repo=try&revision=833c026e160c95640e5705e4022ff69854c40013
Baseline: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b854913c988991c551ffc19fd3eabecc86516871
Assignee | ||
Comment 4•6 years ago
|
||
In comment 3 there are a number of screenshot differences that appear to be unrelated to the patch.
- Changes in the "New to Nightly" font weight on Mac:
https://screenshots.mattn.ca/comparisons/try/b854913c988991c551ffc19fd3eabecc86516871/try/833c026e160c95640e5705e4022ff69854c40013/osx-10-10/primaryUI_271_tabsOutsideTitlebar_fiveTabs_maximized_onlyNavBar_noLWT_compactDensity.png
- Changes in the Windows background:
https://screenshots.mattn.ca/comparisons/try/b854913c988991c551ffc19fd3eabecc86516871/try/833c026e160c95640e5705e4022ff69854c40013/windows10-64/devtools_1_bottomToolbox.png
https://screenshots.mattn.ca/comparisons/try/b854913c988991c551ffc19fd3eabecc86516871/try/833c026e160c95640e5705e4022ff69854c40013/windows10-64/primaryUI_031_tabsInTitlebar_fiveTabs_normal_onlyNavBar_noLWT_compactDensity.png
Matt, do you confirm these are all infrastructure issues?
Flags: needinfo?(MattN+bmo)
Comment 5•6 years ago
|
||
Looks like it. Feel free to update https://github.com/mnoorenberghe/mozscreenshots/blob/master/web/known_inconsistencies.json
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 6•6 years ago
|
||
This is now rebased on top of bug 1421433.
Screenshots: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cebbea2c3fca709ee7c04eba17329f50610a317
Baseline: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c9c0dd2d9cb829ca36c98713d8b1ea009fc346c
Assignee | ||
Updated•6 years ago
|
Attachment #8988127 -
Flags: review?(bgrinstead) → review?(dao+bmo)
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8988127 [details]
Bug 1471544 - Load "menulist.css" as a document stylesheet.
Hm, there is probably a rule still to fix on Linux.
https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=3c9c0dd2d9cb829ca36c98713d8b1ea009fc346c&newProject=try&newRev=0cebbea2c3fca709ee7c04eba17329f50610a317
Attachment #8988127 -
Flags: review?(dao+bmo)
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 8988127 [details]
Bug 1471544 - Load "menulist.css" as a document stylesheet.
Ignore comment 7, I've seen something in the screenshots for "menu.css" and mixed up things. The link shows no regression in the screenshots for "menulist.css".
Attachment #8988127 -
Flags: review?(dao+bmo)
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8988127 [details]
Bug 1471544 - Load "menulist.css" as a document stylesheet.
https://reviewboard.mozilla.org/r/253376/#review261810
Attachment #8988127 -
Flags: review?(dao+bmo) → review+
Comment 10•6 years ago
|
||
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9af50285c1b9
Load "menulist.css" as a document stylesheet. r=dao
Comment 11•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
Assignee: nobody → paolo.mozmail
You need to log in
before you can comment on or make changes to this bug.
Description
•