Closed
Bug 1471631
Opened 6 years ago
Closed 6 years ago
simplify ServiceWorker registration listener code
Categories
(Core :: DOM: Service Workers, enhancement, P2)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 2 obsolete files)
Currently you have to register a listener on the ServiceWorkerManager to receives updates about a particular registration. This could be a lot more simple if we just added these listeners to the ServiceWorkerRegistrationInfo itself.
This is part of my IPC binding layer patch queue.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8988220 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8988251 -
Attachment is obsolete: true
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8988277 [details] [diff] [review]
Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap
This is a refactoring patch I had in my IPC patch queue. It simplifies some of the relationship inside SWM. Previously we stored the list of registration listeners in SWM itself and ServiceWorkerRegistrationInfo had to call out to it to update listeners. This patch simplifies things by making listeners attach to ServiceWorkerRegistrationInfo itself.
Attachment #8988277 -
Flags: review?(mrbkap)
Updated•6 years ago
|
Attachment #8988277 -
Flags: review?(mrbkap) → review+
Updated•6 years ago
|
Priority: -- → P2
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f2a322ea82
Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•