What did you do? ================ 1. Set OS to Japanese. (or browser perferred language) 2. Go to a Japanese MDN url. eg: https://developer.mozilla.org/ja/docs/MDN/Feedback 3. Click the language button top right (from right to left buttons are gear, eye, edit, language. 4. pick English you are then taken to the english URL and asked "You are now viewing this site in English(US) (en-US). Do you always want to view this site in English (US) (en-US?) 5. Pick "YES" 6. Now to go Jaapnese url https://developer.mozilla.org/ja/docs/MDN/Feedback What happened? ============== You get the Japanese page again What should have happened? ========================== You should be redirect to the English page otherwise what was the point of asking in the first place? Either that or if it's not going to work then stop asking? I'm following links from Google and being in Japan those links are almost always Japanese. That's to be expected. Having to switch to English is expect. Being asked if I always want English is great! But not actually having it work and being asked every single time I go to the site is ... well, frustrating Is there anything else we should know? ======================================

I can confirm, this sequence of actions causes the "remember this language preference" dialog to open again, even though English is the "django_language" cookie is already set to "en-US". The system should know not to display a dialog in this case.

I think we should consider review the usercase again! Seems like everyone wants to get it redirect to the chosen language though there are locale in link. I can fix this particular issue, but that would break the user case if the request change their preferred locale to "en" to "de", they will not have any option

>Either that or if it's not going to work then stop asking? I'm following links from Google and being in Japan those links are almost always Japanese. That's to be expected. Having to switch to English is expect. Being asked if I always want English is great! But not actually having it work and being asked every single time I go to the site is ... well, frustrating While we fix the issue, can you press the "Never" button as workaround? so you will not see it again

> Seems like everyone wants to get it redirect to the chosen language though there are locale in link. That could be covered by a new bug, and I'm not sure how we'd do it. For this issue, the scope is: Do not show a dialog asking the user if they want to set django_language to <locale>, if django_language is already set to <locale>.

It appears that when there's a language info in url such as "ja" in "https://developer.mozilla.org/ja/docs/MDN/Feedback", it simply ignores the user's configuration choice in MDN page from the popup. When I tried it without the language info in url like, "https://developer.mozilla.org/docs/MDN/Feedback", it certainly navigates me to the page, remembering my language setup.

Commit pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/a514eeb3d87fa220f020287bbf6e6673bd9d2be5 bug 1471829: Don't prompt to remember the selected language (#4890) Don't show the notification "You are now viewing this site in English (US) (en-US). Do you always want to view this site in English (US)" (or whatever locale), if the user already set that as their override language. Also, track "Yes", "No", and "Never" clicks as Google Analytics events.

Deployed to production