Closed Bug 1471869 Opened 6 years ago Closed 6 years ago

Don't re-attach BrowsingContexts one by one when navigating using bfcache

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Project Flags:
Fission Milestone M2
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: farre, Assigned: farre)

References

(Blocks 1 open bug)

Details

(Whiteboard: [4/29] patches pushed)

Attachments

(1 file)

Bug 1471869 - Re-attach cached contexts in bulk. r=nika
(deleted), text/x-phabricator-request
Details
No description provided.
Blocks: browsingcontext
Priority: -- → P3
Blocks: improve-bc
No longer blocks: browsingcontext
Component: DOM → DOM: Core & HTML

This makes restoring from bfcache send less messages. It also
separates detach/attach from the caching logic, making it more clear
that caching is going on.

Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b98bad3d505e Re-attach cached contexts in bulk. r=nika
Assignee: nobody → afarre
Fission Milestone: --- → M2
Whiteboard: [4/29] patches pushed
Type: defect → enhancement

https://hg.mozilla.org/mozilla-central/rev/b98bad3d505e

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1547911

Note - I've been getting some heavy crashes lately on back-button presses. Mostly on reddit/imgur transitions back (i.e. reddit => imgur, then crash on hitting back), but also on an assortment of other random media sites linked from reddit.

Crash reports seem to point to this bug (notably, crashing on the RELEASE_ASSERT(mChildren.isEmpty())).

https://crash-stats.mozilla.org/report/index/e6333cf7-e6b4-4d9c-beac-30d2e0190507

https://crash-stats.mozilla.org/report/index/47f49828-515d-416c-b9e3-c67f00190507

I've seen multiple of these today.

Flags: needinfo?(afarre)

This has been fixed by bug 1547911 and bug 1549373.

Flags: needinfo?(afarre)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: