debugger - https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce01a110bc55b591a6c015bb8297e2d4f5232d31

devtools - https://treeherder.mozilla.org/#/jobs?repo=try&revision=bdfe966dd9d2c214c37239ab026ea53e34c62958

Comment on attachment 8988618 [details] [diff] [review] 66-1.patch Review of attachment 8988618 [details] [diff] [review]: ----------------------------------------------------------------- Looks like devtools/client/shared/components/reps/reps.js does not have all the changes it should have (i'm thinking of the Services addition in OI, rollback of replacement of explicitOriginalTarget, …). Not sure how the reps bundle was generated

Comment on attachment 8988704 [details] [diff] [review] 66-2.patch Review of attachment 8988704 [details] [diff] [review]: ----------------------------------------------------------------- - I'm seeing the following error in console: ```shell JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/client/debugger/new/src/components/Editor/Preview/Popup.js, line 67: TypeError: relatedTarget.classList is undefined ```` - The README needs an update - I'm seeing this other breakpoint highlight issue which I don't think is specific to the release but worth noting. Will add a screenshot.

Comment on attachment 8988776 [details] [diff] [review] release-66.patch Review of attachment 8988776 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, did you submit to try? Will rebase and land with a green try. ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ +157,4 @@ > skip-if = ccov || (verify && debug && (os == 'linux')) # Bug 1441545 > [browser_dbg-sourcemapped-stepping.js] > [browser_dbg-sourcemapped-preview.js] > +skip-if = os == "win" # Bug 1448523, Bug 1448450 You need to update your mozilla-central to a more recent revision, this diff should not show up and will prevent us from landing.

rebased and pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f97a928ec135fb0659a61e348c6d84d1eb2bb444

David: the try push seems to have a lot of failures. I don't know if my rebased was faulty or something, but can you try to run: devtools/client/debugger/new/test/mochitest/browser_dbg-wasm-sourcemaps.js devtools/client/webconsole/test/mochitest/browser_webconsole_object_inspector_scroll.js and see if they pass for you?

Comment on attachment 8988776 [details] [diff] [review] release-66.patch Review of attachment 8988776 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/shared/components/reps/reps.js @@ +4440,5 @@ > > // Only set default focus to the first tree node if the focus came > // from outside the tree (e.g. by tabbing to the tree from other > // external elements). > + if (relatedTarget !== this.treeRef && !this.treeRef.contains(relatedTarget)) { Actually I missed this, it seems to be a missing sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1469959 It was synced back by Nicolas on debugger.html with https://github.com/devtools-html/debugger.html/commit/ca4daa81f761087f9fa6ca95a677808a4d013118 . It needs to be included in the release as well.

I synced reps and disabled the wasm test devtools - https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a495fe79ea095d0786ce05e739380bc167c3f09 debugger - https://treeherder.mozilla.org/#/jobs?repo=try&revision=28d23b1d0c9b723daaa151d6e1d423e8ee2c1cf1

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e463b28e200 Update Debugger Frontend v66. r=dwalsh

Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1f20fc7d71b Update Debugger Frontend v66 (enable wasm test). r=dwalsh

Backed out for leaks at devtools/client/debugger/new/test/mochitest/browser_dbg-wasm-sourcemaps.js Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ea033f144afe991bc7e2ed6fa68f8798bd2e6d3c Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186019526&repo=mozilla-inbound&lineNumber=7734 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/ae97d490d3dd98066fe53cce532ca995ccaac01e