Closed Bug 1472038 Opened 6 years ago Closed 6 years ago

addon_version is null for "INDEXEDDB_OPEN_FAILED" undesired event

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Iteration:
63.2 - July 23
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: nanj, Assigned: nanj)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4235
(deleted), text/x-github-pull-request
Details
No description provided.
This prevents ETL jobs from loading this particular event into the database. According to the schema, addon_version should not be null for this event.
Assignee: nobody → najiang
Iteration: --- → 63.1 - July 9
Priority: -- → P1
Iteration: 63.1 - July 9 → 63.2 - July 23
A quick glance shows we try to get the version from the store, which gets its value from INIT action. But the undesired event happens before that. Maybe one approach is to not have a store dependency and somehow pass the version to TelemetryFeed constructor?
Iteration: 63.2 - July 23 → 63.3 - Aug 6
Blocks: 1474406
Blocks: 1447130, 1474410
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/848a7dd5ed73d42ca80d2df578f2c4de06c9269b Fix Bug 1472038: Use app build ID for telemetry addon_version https://github.com/mozilla/activity-stream/commit/105a08a353480602b06d24f67d93aca839cf9f53 Merge pull request #4235 from ncloudioj/bz1472038 Fix Bug 1472038: Use app build ID for telemetry addon_version
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1474338
Iteration: 63.3 - Aug 6 → 63.2 - July 23
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: