Closed
Bug 1472081
Opened 6 years ago
Closed 6 years ago
election.gov.np - Override window.sidebar with something falsey
Categories
(Web Compatibility :: Interventions, enhancement)
Web Compatibility
Interventions
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: denschub, Assigned: denschub)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
twisniewski
:
review+
|
Details | Diff | Splinter Review |
As per this comment https://webcompat.com/issues/11622#issuecomment-389476742, overriding window.sidebar with something that evaluates to false gets the form elements working again.
|
Assignee | |
Comment 1•6 years ago
|
||
This PR implements a site patch to override window.sidebar with false, so that the form elements are usable again.
Attachment #8988659 -
Flags: review?(wisniewskit)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8988659 [details] [diff] [review]
Pull Request #25
Review of attachment 8988659 [details] [diff] [review]:
-----------------------------------------------------------------
r+ (notes on GitHub)
Attachment #8988659 -
Attachment is patch: true
Attachment #8988659 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8988659 -
Flags: review?(wisniewskit) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Site patch is landed in our repo on GitHub, so this can be closed. Landing the site patches (and eventually updating Release users via GoFaster) is tracked in bug 1481395.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [sitepatch-built]
|
|
Assignee | |
Updated•3 years ago
|
Whiteboard: [sitepatch-built]
You need to log in
before you can comment on or make changes to this bug.
Description
•