Closed Bug 1472142 Opened 6 years ago Closed 6 years ago

"pick an element from the page" doesn't seem to work with shadow DOM

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox63 verified)

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: smaug, Assigned: jdescottes)

References

Details

Attachments

(2 files, 1 obsolete file)

As an example, load https://mozilla.pettay.fi/moztests/shadow_link.html and try to pick 'in shadow' -link.
I am currently doing some improvement to pick+shadow dom in https://bugzilla.mozilla.org/show_bug.cgi?id=1465873, but it doesn't seem to fix this issue. It seems that the element is correctly selected (breadcrumbs are correct) but the tree is not expanded correctly to reveal it.
Assignee: nobody → jdescottes
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P2
This is quite easy to fix by reusing the last patches from Bug 1465873 and allowing the markup view to navigate from shadowRoot to the host element using what I currently call parentOrHost(). Maybe this method should be renamed as markupViewParent() to indicate this returns the parent node "as represented in the markup view". This bug will be a good time to review our current usage of parentNode() and see where it makes sense to use the new method instead. https://searchfox.org/mozilla-central/search?q=.parentNode()&case=true&regexp=false&path=devtools%2Fclient%2Finspector
Depends on: 1465873
Comment on attachment 8988930 [details] Bug 1472142 - part3: Add mochitest to test picking an element in nested shadow dom; https://reviewboard.mozilla.org/r/254052/#review261370 I haven't reviewed these closely yet, but I think this test is a superset of part 2. Unless if part 2 covers a distinct use case I'd rather drop it and just use this one (faster test runs, less intermittents, etc).
(In reply to Brian Grinstead [:bgrins] from comment #14) > Comment on attachment 8988930 [details] > Bug 1472142 - part3: Add mochitest to test picking an element in nested > shadow dom; > > https://reviewboard.mozilla.org/r/254052/#review261370 > > I haven't reviewed these closely yet, but I think this test is a superset of > part 2. Unless if part 2 covers a distinct use case I'd rather drop it and > just use this one (faster test runs, less intermittents, etc). Good point, folding. Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=47ea11533da7e5c2eb1b5a2b8a8ffc26ac86d030
Attachment #8988930 - Attachment is obsolete: true
Attachment #8988930 - Flags: review?(bgrinstead)
Comment on attachment 8988757 [details] Bug 1472142 - part2: Add mochitest to test picking an element in shadow dom; https://reviewboard.mozilla.org/r/253954/#review262268
Attachment #8988757 - Flags: review?(bgrinstead) → review+
Comment on attachment 8988756 [details] Bug 1472142 - part1: Support picking elements in shadow dom; https://reviewboard.mozilla.org/r/253952/#review262384
Attachment #8988756 - Flags: review?(bgrinstead) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c0f51f57b2f part1: Support picking elements in shadow dom;r=bgrins https://hg.mozilla.org/integration/autoland/rev/0c4629d8d2ab part2: Add mochitest to test picking an element in shadow dom;r=bgrins
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: qe-verify+
Flags: needinfo?(timea.zsoldos)
I have reproduced this issue using Firefox 62.0a1 (2018.06.29) on Windows 10 x64. I can confirm this issue is fixed, I verified using Firefox 63.0b3 on Ubuntu 16.04 x64, Windows 10 x64 and Mac OS X 10.13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(timea.zsoldos)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: