Sören Hentzschel Reporter
	Description • 6 years ago

[Tracking Requested - why for this release]:

With the latest Nightly sometimes the favicons don't load and there is the default Firefox (Nightly) favicon. I can't run mozregression on this computer but I bet it's a regression from bug 1453751. I also don't have reliable steps to reproduce but I attached a screenshot to prove that the problem is real.

	Sören Hentzschel Reporter
	Comment 1 • 6 years ago

There are more regressions, probably related, so I won't file a new bug.

On some websites, for example ghacks.net, even if it works, there is annoying flickering because first the Nightly icon is visible before it gets replaced. That's also a regression and probably related. This regression is reproducible in 100%.

After testing this I loaded the website kicker.de in a new tab and this webseite had the favicon of ghacks.net in the tab…

	TMart
	Comment 2 • 6 years ago

My restored tabs almost completely lost their favicons. Most sites need a refresh to show their correct favicons again.

	Dave Townsend [:mossop]
	Comment 3 • 6 years ago

(In reply to TMart from comment #2)
> My restored tabs almost completely lost their favicons. Most sites need a
> refresh to show their correct favicons again.

Please file that separately.

	Dave Townsend [:mossop]
	Comment 4 • 6 years ago

(In reply to Dave Townsend [:mossop] from comment #3)
> (In reply to TMart from comment #2)
> > My restored tabs almost completely lost their favicons. Most sites need a
> > refresh to show their correct favicons again.
> 
> Please file that separately.

Actually, I know what this is, filed bug 1472476.

	Dave Townsend [:mossop]
	Comment 5 • 6 years ago

(In reply to Sören Hentzschel from comment #1)
> Created attachment 8988977 [details]
> wrong favicon
> 
> There are more regressions, probably related, so I won't file a new bug.
> 
> On some websites, for example ghacks.net, even if it works, there is
> annoying flickering because first the Nightly icon is visible before it gets
> replaced. That's also a regression and probably related. This regression is
> reproducible in 100%.

Filed bug 1472475.

	Dave Townsend [:mossop]
	Comment 6 • 6 years ago

Are you still seeing issues with the latest nightly?

	TMart
	Comment 7 • 6 years ago

I'm still seeing sites without favicons with the latest Nightly. Not even the Nightly logo is shown when that happens.

	Sören Hentzschel Reporter
	Comment 8 • 6 years ago

I don't have any favicons issue with the latest Nightly.

	Dave Townsend [:mossop]
	Comment 9 • 6 years ago

Let's close this then. Feel free to open new bugs if you see more issues.

	Dave Townsend [:mossop]
	Comment 10 • 6 years ago

(In reply to TMart from comment #7)
> I'm still seeing sites without favicons with the latest Nightly. Not even
> the Nightly logo is shown when that happens.

Oops, missed this comment. Can you please file a new bug with the specific sites where you're having issues.

	TMart
	Comment 11 • 6 years ago

It doesn't work in two of my old Nightly profiles. However in a new profile it seems to work. I deleted favicons.sqlite, but that didn't change anything. Is there anything else that could help?

	Dave Townsend [:mossop]
	Comment 12 • 6 years ago

(In reply to TMart from comment #11)
> It doesn't work in two of my old Nightly profiles. However in a new profile
> it seems to work. I deleted favicons.sqlite, but that didn't change
> anything. Is there anything else that could help?

The specific sites that you're seeing problems with and anything listed in the browser console.

	TMart
	Comment 13 • 6 years ago

I often get it on www.gamestar.de/xenforo/ or www.qz.com

Browser console shows errors like this: 
[Exception... "Favicon load from https://www.gamestar.de/favicon.ico was cancelled." nsresult: "0x804b0002 (NS_BINDING_ABORTED)" location: "JS frame :: resource:///modules/ContentLinkHandler.jsm :: cancel :: line 108" data: no]

I also get no favicon on www.theatlantic.com, but I can find no correspoding error in browser console.

	Dave Townsend [:mossop]
	Comment 14 • 6 years ago

(In reply to TMart from comment #13)
> I often get it on www.gamestar.de/xenforo/

I've filed bug 1473264 for this.