Closed
Bug 1472430
Opened 6 years ago
Closed 6 years ago
[FIX] PresShell should not use IsInUncomposedDoc
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → bugs
Attachment #8988985 -
Flags: review?(emilio)
|
|
Assignee | |
Updated•6 years ago
|
Summary: PresShell should not use IsInUncomposedDoc → [FIX] PresShell should not use IsInUncomposedDoc
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8988985 [details] [diff] [review]
isincomposeddoc_presshell.diff
Review of attachment 8988985 [details] [diff] [review]:
-----------------------------------------------------------------
Hmm, so this is only used to draw the drag icon stuff, interesting.
Looks good, thank you. It'll always amuse me the variety of code we have in PresShell.cpp
Attachment #8988985 -
Flags: review?(emilio) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/970eb8cb67de
PresShell::RenderNode should work with elements in Shadow DOM, r=emilio
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•