Closed
Bug 1472575
Opened 6 years ago
Closed 6 years ago
Add delay to baseline coverage tests.
Categories
(Testing :: Code Coverage, enhancement)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: sparky, Assigned: sparky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This bug is for adding a 30 second delay to the baseline coverage tests to help stabilize (or to decrease the variability of) their code coverage results over time.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•6 years ago
|
||
Here's a link to a try run that uses these delay's: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e63190628a0a505457e86ba5f13f3b9ec0bcdff
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8989090 [details]
Bug 1472575 - Add delay to baseline coverage tests.
https://reviewboard.mozilla.org/r/254152/#review260936
::: testing/mochitest/baselinecoverage/browser_chrome/browser_baselinecoverage.js:10
(Diff revision 1)
> "use strict";
>
> +const { setTimeout } = ChromeUtils.import("resource://gre/modules/Timer.jsm", {});
> +
> add_task(async function() {
> + requestLongerTimeout(45);
this value is a multiple of how many times longer to run, so in this case if the default timeout is 30 seconds, we are now running for 1350 seconds. I believe the default is more like 45 seconds:
https://searchfox.org/mozilla-central/source/testing/mochitest/browser-test.js#8
possibly move this to a value of 2
::: testing/mochitest/baselinecoverage/chrome/test_baselinecoverage.xul:14
(Diff revision 1)
> <window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
> <script type="application/javascript"
> src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js" />
> <script type="application/javascript"><![CDATA[
> + SimpleTest.waitForExplicitFinish();
> + SimpleTest.requestLongerTimeout(45);
this is again a factor, not seconds and I believe the default timeout here is 300 seconds:
https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/TestRunner.js#91
this is everything mochitest except browser-chrome/devtools.
maybe we don't need it in this case.
::: testing/mochitest/baselinecoverage/plain/test_baselinecoverage.html:11
(Diff revision 1)
> <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
> </head>
> <body>
> <script type="application/javascript">
> + SimpleTest.waitForExplicitFinish();
> + SimpleTest.requestLongerTimeout(45);
same comment as above for the .xul case.
Attachment #8989090 -
Flags: review?(jmaher) → review-
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8989090 [details]
Bug 1472575 - Add delay to baseline coverage tests.
https://reviewboard.mozilla.org/r/254152/#review261046
this looks better, thanks
Attachment #8989090 -
Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/959983b7d19e
Add delay to baseline coverage tests. r=jmaher
|
|
Assignee | |
Comment 7•6 years ago
|
||
Here's a link to a try push with the latest changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=542acc5d5acb496b6e1915c9987cdbd33dba03ee
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Assignee: nobody → gmierz2
You need to log in
before you can comment on or make changes to this bug.
Description
•