Closed
Bug 1472650
Opened 6 years ago
Closed 6 years ago
[FIX] nsCSSRendering::ShouldPaintBoxShadowInner should probably use GetComposedDoc
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → bugs
Attachment #8989242 -
Flags: review?(emilio)
|
|
Assignee | |
Updated•6 years ago
|
Summary: nsCSSRendering::ShouldPaintBoxShadowInner should probably use GetComposedDoc → [FIX] nsCSSRendering::ShouldPaintBoxShadowInner should probably use GetComposedDoc
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8989242 [details] [diff] [review]
nsCSSRendering_composeddoc.diff
Review of attachment 8989242 [details] [diff] [review]:
-----------------------------------------------------------------
This may as well just use OwnerDoc(). If the content has a frame it needs to be InComposedDoc anyway.
r=me with or without that.
Attachment #8989242 -
Flags: review?(emilio) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f038004f24c7
nsCSSRendering::ShouldPaintBoxShadowInner should use GetComposedDoc, r=emilio
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•