The tab actor events were not updated to protocol.js. Protocol.js has its own way of handling events and we should use that instead

Comment on attachment 8989703 [details] Bug 1472670 - use Protocol.js events instead of this.conn.send; https://reviewboard.mozilla.org/r/254718/#review261586 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: devtools/shared/specs/targets/browsing-context.js:135 (Diff revision 1) > + }, > + frameUpdate: { > + type: "frameUpdate", > + frames: Option(0, "nullable:array:browsingContextTarget.window"), > + selected: Option(0, "nullable:number") > + destroyAll: Option(0, "nullable:boolean") Error: Parsing error: unexpected token destroyall [eslint]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02576b2bd6d6a8d2321dedea95102858fc660b76

Comment on attachment 8989703 [details] Bug 1472670 - use Protocol.js events instead of this.conn.send; https://reviewboard.mozilla.org/r/254718/#review261626 Thanks, it looks good. It would be great to push to DAMP before merging as I know that protocol.js events can be slow depending on the types... I had to workaround that for netmonitor actor. ::: devtools/client/debugger/new/src/client/firefox/events.js:104 (Diff revision 3) > paused, > resumed, > newSource > }; > exports.setupEvents = setupEvents; > exports.clientEvents = clientEvents; It is not very clear why this file appear on mozreview, it doesn't show any particular difference? ::: devtools/shared/specs/targets/browsing-context.js:59 (Diff revision 3) > + url: "string", > + title: "string", > + nativeConsoleAPI: "boolean", > + state: "string", > + isFrameSwitching: "boolean" > +}); This is unused.

talos run: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=bad32c3d7010501987ea20b9b12bdc1fbe892dd6&framework=1&selectedTimeRange=172800

Comparison to its base branch: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=a83c2d47d7833239405c2bf33958627aa6bb3075&newProject=try&newRevision=bad32c3d7010501987ea20b9b12bdc1fbe892dd6&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&framework=1

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa92a04dda3d use Protocol.js events instead of this.conn.send; r=ochameau