Dão Gottwald [:dao] Reporter
	Description • 6 years ago

Since tabbrowser itself doesn't load icons from the network anymore, I suppose this error handling isn't needed anymore. Is there a risk that we get invalid data URIs or something?

https://searchfox.org/mozilla-central/rev/97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.xml#116

https://searchfox.org/mozilla-central/rev/97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.js#2223

	Dave Townsend [:mossop]
	Comment 1 • 6 years ago

We should never get invalid data URIs to my knowledge. We do still have some cases where we pass the icon url directly through when they are chrome: for example so maybe if they are broken this still might have some effect. Probably not needed though.

	Manish [:manishkk] Assignee
	Comment 2 • 6 years ago

Need to remove these lines only?


> https://searchfox.org/mozilla-central/rev/
> 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> xml#116
> 
> https://searchfox.org/mozilla-central/rev/
> 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> js#2223

	Dão Gottwald [:dao] Reporter
	Comment 3 • 6 years ago

(In reply to Manish Kumar [:manishkk] from comment #2)
> Need to remove these lines only?
> 
> 
> > https://searchfox.org/mozilla-central/rev/
> > 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> > xml#116
> > 
> > https://searchfox.org/mozilla-central/rev/
> > 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> > js#2223

Yep.

	Manish [:manishkk] Assignee
	Comment 4 • 6 years ago

Please review.

Thanks

	Dão Gottwald [:dao] Reporter
	Comment 5 • 6 years ago

Comment on attachment 8990775 [details] [diff] [review]
Patch_Bug1473253

Looks good, thanks!

	Pulsebot
	Comment 6 • 6 years ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f823c4cfd7ce
Stop setting onerror attribute on tabs. r=dao

	Andreea Pavel [:apavel]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f823c4cfd7ce