"Clear Private Data -> Saved Logins" interacts poorly with Sync
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(fennec?, firefox64 wontfix, firefox65 wontfix, firefox66+ verified)
People
(Reporter: markh, Assigned: petru)
References
Details
(Keywords: dataloss)
Attachments
(3 files, 3 obsolete files)
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Updated•6 years ago
|
Comment 6•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Noting this isn't a regression and changing the priority to P1 since it means user data loss.
Assignee | ||
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Comment 15•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 16•6 years ago
|
||
I've added new patches for JanH's recommended flow.
The "Saved logins" option will be removed from the "Clear private data" options.
Users can now only remove logins from "about:login" where a prompt informs Sync users that deleting a login/all of them - "This can affect synced logins"
Don't know if the "passwords" option from Sanitizer[1] (which was previously called from "Clear private data" to remove logins) is really used/useful to some other parts of the code so I haven't removed it.
Assignee | ||
Comment 17•6 years ago
|
||
Added geckoview-reviewers in Phabricator for the above patches to not let this all rest on JanH's shoulders.
Assignee | ||
Updated•6 years ago
|
Comment 18•6 years ago
|
||
Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7034ada9fb3
Part 1 - Add new "Delete all" option to about:logins; r=JanH
Comment 19•6 years ago
|
||
:petru tried to land the patches on Phabricator, but when landing part 2 encountered this error Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmp05zHZc\npatching file mobile/android/locales/en-US/chrome/aboutLogins.properties\nHunk #1 FAILED at 6\nHunk #2 FAILED at 22\n2 out of 2 hunks FAILED -- saving rejects to file mobile/android/locales/en-US/chrome/aboutLogins.properties.rej\npatching file mobile/android/chrome/content/aboutLogins.js\nHunk #2 FAILED at 367\nHunk #3 FAILED at 388\n2 out of 3 hunks FAILED -- saving rejects to file mobile/android/chrome/content/aboutLogins.js.rej\nabort: patch failed to apply', '')
Could you please take a look?
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 20•6 years ago
|
||
I think it should work now.
Comment 21•6 years ago
|
||
:petru , still not working.
On Mon, January 14, 2019, 8:54 PM GMT+2, by nbeleuzu@mozilla.com.
Revisions: D16027 diff 51388 ← D16029 diff 51395
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpRbvTy2\npatching file mobile/android/locales/en-US/chrome/aboutLogins.properties\nHunk #1 FAILED at 6\nHunk #2 FAILED at 22\n2 out of 2 hunks FAILED -- saving rejects to file mobile/android/locales/en-US/chrome/aboutLogins.properties.rej\npatching file mobile/android/chrome/content/aboutLogins.js\nHunk #2 FAILED at 367\nHunk #3 FAILED at 388\n2 out of 3 hunks FAILED -- saving rejects to file mobile/android/chrome/content/aboutLogins.js.rej\nabort: patch failed to apply', '')
Updated•6 years ago
|
Comment 22•6 years ago
|
||
bugherder |
Assignee | ||
Updated•6 years ago
|
Comment 24•6 years ago
|
||
Petru, part 2 and 3 have problems rebasing, could you please take a look over this? Thanks.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpWZ56rL\npatching file mobile/android/locales/en-US/chrome/aboutLogins.properties\nHunk #1 FAILED at 6\nHunk #2 FAILED at 22\n2 out of 2 hunks FAILED -- saving rejects to file mobile/android/locales/en-US/chrome/aboutLogins.properties.rej\npatching file mobile/android/chrome/content/aboutLogins.js\nHunk #1 FAILED at 4\nHunk #2 FAILED at 366\nHunk #3 FAILED at 387\n3 out of 3 hunks FAILED -- saving rejects to file mobile/android/chrome/content/aboutLogins.js.rej\nabort: patch failed to apply', '')
Updated•6 years ago
|
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
This was successfully landed so clearing the needinfo.
Comment 27•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ae52a3250ebf
https://hg.mozilla.org/mozilla-central/rev/5d0fef351a29
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment 28•6 years ago
|
||
Verified as fixed on Nightly 66.0a1 (2019-01-16).
Updated•6 years ago
|
Updated•4 years ago
|
Description
•