Michael Shal [:mshal] Assignee
	Description • 6 years ago

Bug 1461714 would like to add some GENERATED_FILES with multiple outputs that will produce files used by install manifests, roughly looking like this:

GENERATED_FILES += [('output1', 'output2', ...)]
FINAL_TARGET_FILES.foo += ['!output1', '!output2', ...]

This causes the FasterMake backend to invoke 'make -C dirname filename' for each of the outputs so the GENERATED_FILES are built by the RecursiveMake backend before the install manifest is processed by the FasterMake backend: https://dxr.mozilla.org/mozilla-central/rev/6c0fa9a675c91390ca27664ffb626c56e8afea4d/config/faster/rules.mk#73

This works fine for GENERATED_FILES with single outputs, which are currently the only ones that are used in install manifests, and therefore trigger this rule. However, with multiple outputs, the RecursiveMake backend is invoked multiple times to build the same set of files, potentially in parallel.

We should support this better in the FasterMake backend by ensuring that the rule is only invoked once.

	Gregory Szorc [:gps]
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8990077 [details]
Bug 1473667 - Handle multiple GENERATED_FILES outputs in the faster make backend;

https://reviewboard.mozilla.org/r/255090/#review265918

	Pulsebot
	Comment 3 • 6 years ago

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f316cbb31c28
Handle multiple GENERATED_FILES outputs in the faster make backend; r=gps

	Andreea Pavel [:apavel]
	Comment 4 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f316cbb31c28