Closed Bug 1473813 Opened 6 years ago Closed 6 years ago

::before { content: <single-url> } should keep creating a non-replaced box wrapping the content.

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: regression)

Attachments

(1 file)

      No description provided.
[Tracking Requested - why for this release]: Behavior change that may not be desired.
Priority: -- → P3
Comment on attachment 8990211 [details]
Bug 1473813: Don't make pseudo-elements replaced by content: url(..).

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D1996
Attachment #8990211 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93e4dff7e346
Don't make pseudo-elements replaced by content: url(..). r=bz
Backed out 2 changesets (bug 1473813, bug 1472403) for bustages in /builds/worker/workspace/build/src/dom/base/MessageSender.cpp:24:19 on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=63239b786a26cfd8778106916eb21ddf4fa67bed&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=188374654
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=63239b786a26cfd8778106916eb21ddf4fa67bed&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=188374654&repo=mozilla-inbound&lineNumber=1106

[task 2018-07-16T15:43:18.277Z] 15:43:18     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/base/Unified_cpp_dom_base3.cpp:2:
[task 2018-07-16T15:43:18.278Z] 15:43:18     INFO -  /builds/worker/workspace/build/src/dom/base/MessageSender.cpp:24:19: error: member access into incomplete type 'mozilla::dom::MessageBroadcaster'
[task 2018-07-16T15:43:18.279Z] 15:43:18     INFO -      mParentManager->AddChildManager(this);
[task 2018-07-16T15:43:18.279Z] 15:43:18     INFO -                    ^
[task 2018-07-16T15:43:18.281Z] 15:43:18     INFO -  /builds/worker/workspace/build/src/dom/base/nsFrameMessageManager.h:52:7: note: forward declaration of 'mozilla::dom::MessageBroadcaster'
[task 2018-07-16T15:43:18.282Z] 15:43:18     INFO -  class MessageBroadcaster;
[task 2018-07-16T15:43:18.283Z] 15:43:18     INFO -        ^
[task 2018-07-16T15:43:18.284Z] 15:43:18     INFO -  1 error generated.
[task 2018-07-16T15:43:18.285Z] 15:43:18     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1052: recipe for target 'Unified_cpp_dom_base3.o' failed
[task 2018-07-16T15:43:18.286Z] 15:43:18     INFO -  make[4]: *** [Unified_cpp_dom_base3.o] Error 1
[task 2018-07-16T15:43:18.286Z] 15:43:18     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/base'
[task 2018-07-16T15:43:18.287Z] 15:43:18     INFO -  make[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f711e5a3524
Don't make pseudo-elements replaced by content: url(..). r=bz
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12011 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/2f711e5a3524
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Upstream PR was closed without merging
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: