Closed
Bug 1473954
Opened 6 years ago
Closed 6 years ago
Use ASOUTOPTION for SOBJS
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We're passing the wrong flag (`-o ` rather than `-Fo`) to ml64 aka $(AS):
10:14:03 INFO - ml64.exe -o SkJumper_generated_win.obj [...]
10:14:03 INFO - MASM : warning A4018:invalid command-line option : -o
I guess it goes unnoticed because ml64 defaults to an .obj extension?
But this is going to trip up clang-cl pseudo-PGO builds in bug 1444171 when we start giving object files the .i_o extension.
Attachment #8990357 -
Attachment is patch: true
Attachment #8990357 -
Flags: review?(core-build-config-reviews)
|
||
Updated•6 years ago
|
Attachment #8990357 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a35d5c3158e
Use $(ASOUTOPTION) rather than hardcode -o for SOBJS. r=ted
|
||
Comment 3•6 years ago
|
||
Bug 1473117 had the same patch already r+ed.
(In reply to Mike Hommey [:glandium] from comment #3)
> Bug 1473117 had the same patch already r+ed.
Oops. I missed that because it wasn't linked to bug 1444171.
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•